"current_time_" variable in J2Erosion_Def.hpp doesn't seem to update appropriately -- this affects correct interpolation and application of time dependent variables in J2Erosion such as sea level

[ebayats]

Included here is a modified MiniErosion test called “MiniErosion-test-sea-level” to showcase this issue .

Essentially, the “current_time_” variable in J2Erosion_Def.hpp obtained via “current_time_ = workset.current_time” (line 237) is either a value of 0 or 450 (the timestep size), rather than the actual time value of the simulation (i.e. ranging from 0 - 64800.0). This causes an issue because in cases like the full bluff case, the sea level is obtained by interpolating the user-provided sea level array to the correct simulation time to obtain the current sea level for the given timestep. I first noticed this behavior in the bluff scale simulation.

Attached is a tar file that showcases the issue. Essentially I am providing a sea level that looks like:

But if you print out the sea level that is being used in J2Erosion_Def.hpp at each timestep, it only ever reads a sea level of 0.5 (one of the first values in the array). This is because the simulation time of the problem is not being correctly obtained.

MiniErosion-test-sea-level.tar.gz