Build tmxparser library failed

[vanluom123]

Hello, i have a problem while building tmxparser library. The problem follow as below.
Please, help me fix it. Thanks!

1>------ Build started: Project: tmxparser, Configuration: Debug Win32 ------
2>------ Build started: Project: tmxparser_static, Configuration: Debug Win32 ------
2>Building Custom Rule C:/Users/phanv/Desktop/tmxparser/CMakeLists.txt
1>cl : command line error D8021: invalid numeric argument '/Werror=strict-prototypes'
1>Done building project "tmxparser.vcxproj" -- FAILED.
3>------ Build started: Project: run_tests, Configuration: Debug Win32 ------
2>cl : command line error D8021: invalid numeric argument '/Werror=strict-prototypes'
3>Building Custom Rule C:/Users/phanv/Desktop/tmxparser/CMakeLists.txt
3>cl : command line error D8021: invalid numeric argument '/Werror'
2>Done building project "tmxparser_static.vcxproj" -- FAILED.
3>Done building project "run_tests.vcxproj" -- FAILED.
4>------ Build started: Project: ALL_BUILD, Configuration: Debug Win32 ------
4>Building Custom Rule C:/Users/phanv/Desktop/tmxparser/CMakeLists.txt
========== Build: 1 succeeded, 3 failed, 1 up-to-date, 0 skipped ==========

[Pingimingi22]

/Werror type commands are a GCC/Clang thing and don't work in Visual Studio. I got around this error by going into my Visual Studio solution and opening up the project properties for the tmxparser project. Under Configuration Properties go to C/C++ and and then Command Line. I removed the /Werror commands from there and those errors were fixed. You could also find where these commands are being set in one of the CMakeLists.txt files and remove them there.

[AzP]

I got a related issue on GCC 12.2.1. It looks like the build arguments should perhaps be removed nowadays.

[1/24] Building CXX object CMakeFiles/tmxparser.dir/src/TmxEllipse.cpp.o
cc1plus: warning: ‘-Werror=’ argument ‘-Werror=strict-prototypes’ is not valid for C++
cc1plus: warning: ‘-Werror=’ argument ‘-Werror=old-style-definition’ is not valid for C++
cc1plus: warning: ‘-Werror=’ argument ‘-Werror=missing-prototypes’ is not valid for C++

[vanluom123]

@AzP I removed flags and it worked fine on CMake to build the library. Thanks!

[AzP]

@AzP I removed flags and it worked fine on CMake to build the library. Thanks!

@vanluom123, I'm happy I could help!

It seems the PR is still not approved though. If the fix isn't in, the bug still exist in the repository, so the bug should be kept open.

[vanluom123]

Okay, @AzP. I will reopen this issue. It will be closed when PR is merged