Skip to content

Make ONNX support optional#13

Merged
mtavenrath merged 2 commits into
rustnn:mainfrom
theHamsta:onnx-optional
May 31, 2026
Merged

Make ONNX support optional#13
mtavenrath merged 2 commits into
rustnn:mainfrom
theHamsta:onnx-optional

Conversation

@theHamsta

@theHamsta theHamsta commented May 4, 2026

Copy link
Copy Markdown
Contributor

Name for feature: "onnx" or "onnx-support"
Make onnx support default?

@theHamsta theHamsta changed the title Onnx optional Make ONNX support optional May 4, 2026
@theHamsta theHamsta force-pushed the onnx-optional branch 3 times, most recently from 5262e31 to af13439 Compare May 4, 2026 09:10
Comment thread .github/workflows/ci.yml
jobs:
test:
name: Test on ${{ matrix.os }}
name: Test (${{ matrix.os }}, minimal=${{ matrix.minimal }})

@theHamsta theHamsta May 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made separate tags to have on env with and one without protoc (needing protoc in CI env is a pitfall for someone trying to use webnn-graph)

@theHamsta theHamsta force-pushed the onnx-optional branch 11 times, most recently from db01059 to 5ff7bbf Compare May 4, 2026 09:50
@theHamsta theHamsta requested a review from tarekziade May 4, 2026 09:52
@theHamsta

Copy link
Copy Markdown
Contributor Author

Preparation for rustnn/rustnn#89

@theHamsta theHamsta force-pushed the onnx-optional branch 2 times, most recently from 5a362ed to bac845f Compare May 22, 2026 07:39
@mtavenrath mtavenrath merged commit 075e3c2 into rustnn:main May 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants