[Bug]: Fixes-magic link issues#137
Open
JMR825 wants to merge 1 commit into
Open
Conversation
|
@JMR825 is attempting to deploy a commit to the participationcorner2025-8967's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 SummaryThe provided pull request diff introduces significant changes to the 📂 Files Changed
🎭 Code PoemCode changes abound, with care and might, 🚨 Bugs & Architectural Violations* The `MagicLinkOption` component is placed in the correct directory (`app/blocks/`). * However, the use of `import.meta.env` may not be compatible with all environments. It's recommended to use a more robust method for handling environment variables. * The `getSupabaseClient` function in `magic-link-option.tsx` has a similar implementation to the `getSupabaseBrowserClient` function in `supabase.client.ts`. Consider extracting a separate utility function to avoid code duplication. * The `style` attribute is used to set the color of the error message. Consider using a CSS class instead to maintain consistency with the rest of the codebase. * The `MagicLinkOption` component does not have any accessibility attributes (e.g., `aria-hidden`, `role`). Consider adding these attributes to improve accessibility.💡 Suggestions & Best Practices* Consider using a more robust method for handling environment variables, such as using a library like `dotenv` or `env-var`. * Extract a separate utility function to handle Supabase client creation to avoid code duplication. * Use CSS classes instead of the `style` attribute to maintain consistency with the rest of the codebase. * Add accessibility attributes (e.g., `aria-hidden`, `role`) to the `MagicLinkOption` component to improve accessibility. * Consider using a more robust method for handling errors, such as using a library like `error-handler` or `error-boundary`. * Use a consistent naming convention throughout the codebase (e.g., use either camelCase or PascalCase for variable and function names). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the placeholder Magic Link component on the login page to fully implement passwordless authentication using Supabase. It implements user email collection, adds client-side data validation constraints, integrates the native
signInWithOtpdispatch flow, and implements defensive environment checks to handle runtime evaluation differences gracefullyRelated Issues
closes #105
Type of Change
bug fixed.
Screenshots
if no email is provided
magic email msg from supabase