From e7c5b888cf6aa93d26c56aee68e6e7d930869432 Mon Sep 17 00:00:00 2001 From: Siddarth Chalasani Date: Mon, 24 Nov 2025 17:04:30 -0800 Subject: [PATCH 1/2] update parameters for manually maintained start_run_and_await_env_ready methods --- .../resources/scenarios/scenarios.py | 30 ++++++++++++------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/src/runloop_api_client/resources/scenarios/scenarios.py b/src/runloop_api_client/resources/scenarios/scenarios.py index df926342e..d5d5afa62 100644 --- a/src/runloop_api_client/resources/scenarios/scenarios.py +++ b/src/runloop_api_client/resources/scenarios/scenarios.py @@ -30,7 +30,7 @@ ScorersResourceWithStreamingResponse, AsyncScorersResourceWithStreamingResponse, ) -from ..._types import NOT_GIVEN, Body, Omit, Query, Headers, NotGiven, SequenceNotStr, omit, not_given +from ..._types import Body, Omit, Query, Headers, NotGiven, SequenceNotStr, omit, not_given from ..._utils import maybe_transform, async_maybe_transform from ..._compat import cached_property from ..._resource import SyncAPIResource, AsyncAPIResource @@ -457,17 +457,17 @@ def start_run_and_await_env_ready( self, *, scenario_id: str, - benchmark_run_id: Optional[str] | NotGiven = NOT_GIVEN, - metadata: Optional[Dict[str, str]] | NotGiven = NOT_GIVEN, - run_name: Optional[str] | NotGiven = NOT_GIVEN, - run_profile: Optional[scenario_start_run_params.RunProfile] | NotGiven = NOT_GIVEN, + benchmark_run_id: Optional[str] | Omit = omit, + metadata: Optional[Dict[str, str]] | Omit = omit, + run_name: Optional[str] | Omit = omit, + run_profile: Optional[scenario_start_run_params.RunProfile] | Omit = omit, polling_config: PollingConfig | None = None, # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs. # The extra values given here take precedence over values defined on the client or passed to this method. extra_headers: Headers | None = None, extra_query: Query | None = None, extra_body: Body | None = None, - timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN, + timeout: float | httpx.Timeout | None | NotGiven = not_given, idempotency_key: str | None = None, ) -> ScenarioRunView: """Start a new ScenarioRun and wait for its environment to be ready. @@ -913,11 +913,16 @@ async def start_run( async def start_run_and_await_env_ready( self, scenario_id: str, - benchmark_run_id: Optional[str] | NotGiven = NOT_GIVEN, - metadata: Optional[Dict[str, str]] | NotGiven = NOT_GIVEN, - run_name: Optional[str] | NotGiven = NOT_GIVEN, - run_profile: Optional[scenario_start_run_params.RunProfile] | NotGiven = NOT_GIVEN, + benchmark_run_id: Optional[str] | Omit = omit, + metadata: Optional[Dict[str, str]] | Omit = omit, + run_name: Optional[str] | Omit = omit, + run_profile: Optional[scenario_start_run_params.RunProfile] | Omit = omit, polling_config: PollingConfig | None = None, + extra_headers: Headers | None = None, + extra_query: Query | None = None, + extra_body: Body | None = None, + timeout: float | httpx.Timeout | None | NotGiven = not_given, + idempotency_key: str | None = None, ) -> ScenarioRunView: """Start a new ScenarioRun and wait for its environment to be ready. @@ -941,6 +946,11 @@ async def start_run_and_await_env_ready( metadata=metadata, run_name=run_name, run_profile=run_profile, + extra_headers=extra_headers, + extra_query=extra_query, + extra_body=extra_body, + timeout=timeout, + idempotency_key=idempotency_key, ) await self._client.devboxes.await_running( From 2f6d162f83e5dd07d377d38dc2148d633596789d Mon Sep 17 00:00:00 2001 From: Siddarth Chalasani Date: Mon, 24 Nov 2025 17:12:34 -0800 Subject: [PATCH 2/2] added helper comment (maintains consistency) --- src/runloop_api_client/resources/scenarios/scenarios.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/runloop_api_client/resources/scenarios/scenarios.py b/src/runloop_api_client/resources/scenarios/scenarios.py index d5d5afa62..6b7c729f4 100644 --- a/src/runloop_api_client/resources/scenarios/scenarios.py +++ b/src/runloop_api_client/resources/scenarios/scenarios.py @@ -918,6 +918,8 @@ async def start_run_and_await_env_ready( run_name: Optional[str] | Omit = omit, run_profile: Optional[scenario_start_run_params.RunProfile] | Omit = omit, polling_config: PollingConfig | None = None, + # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs. + # The extra values given here take precedence over values defined on the client or passed to this method. extra_headers: Headers | None = None, extra_query: Query | None = None, extra_body: Body | None = None,