update execute_and_await_completion params#668
Merged
Conversation
alb-rl
approved these changes
Nov 14, 2025
alb-rl
left a comment
alb-rl
left a comment
Contributor
There was a problem hiding this comment.
Looks good, left one small comment
| Execute a command and wait for it to complete with optimal latency for long running commands. | ||
|
|
||
| This method launches an execution with a generated command_id and first attempts to | ||
| This method launches an execution and first attempts to |
Contributor
There was a problem hiding this comment.
maybe add a comment about how the command_id is generated unless the user wants to use a specific one. Then explain the purpose of command ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute_and_await_completionis a convenience wrapper over the base API'sexecutemethod. This change updates the wrapper to accept the newlast_nandoptimistic_timeoutparameters, and exposescommand_idas a passable parameter to enable command-level idempotency for the user.