From 061e958460dd28825b908d17f3bb96b1329f974c Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 18 Jun 2026 14:49:01 +0000 Subject: [PATCH 1/2] ci: clear MAKEFLAGS so nmake works on the mswin build The mswin (MSVC) job builds native gem extensions with `nmake`, which aborts with "NMAKE : fatal error U1065: invalid option '-'" when it inherits a GNU-make-style MAKEFLAGS from the environment. This broke `bundle install` (and would break `rake compile`) for the mswin matrix entry, while the mingw/UCRT GNU make builds tolerated the flag. Clear MAKEFLAGS for the compile job so nmake receives no flags. It is a harmless no-op for the GNU make builds. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_014RENNXiMZ7ihuquCwKM4Ht --- .github/workflows/windows.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index da184e05d..74a657fe2 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -13,6 +13,12 @@ permissions: jobs: compile: runs-on: "windows-latest" + env: + # The mswin (MSVC) build uses `nmake`, which aborts with + # "NMAKE : fatal error U1065: invalid option '-'" when it inherits a + # GNU-make-style MAKEFLAGS from the environment. Clear it so nmake gets no + # flags; this is a harmless no-op for the mingw/UCRT GNU make builds. + MAKEFLAGS: "" strategy: fail-fast: false matrix: From 5f6179e5f724419ba1e62c8ff9881281d061674f Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 18 Jun 2026 15:00:15 +0000 Subject: [PATCH 2/2] ci: TEMP diagnostic - print inherited MAKEFLAGS on the Windows build Temporarily print the raw MAKEFLAGS/MFLAGS values before clearing them in-script, to confirm what value the mswin nmake build was choking on. The in-script clear keeps the build green. This will be reverted to the clean job-level `env: MAKEFLAGS: ""` fix once the value is captured. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_014RENNXiMZ7ihuquCwKM4Ht --- .github/workflows/windows.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 74a657fe2..61fd760de 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -13,12 +13,6 @@ permissions: jobs: compile: runs-on: "windows-latest" - env: - # The mswin (MSVC) build uses `nmake`, which aborts with - # "NMAKE : fatal error U1065: invalid option '-'" when it inherits a - # GNU-make-style MAKEFLAGS from the environment. Clear it so nmake gets no - # flags; this is a harmless no-op for the mingw/UCRT GNU make builds. - MAKEFLAGS: "" strategy: fail-fast: false matrix: @@ -49,7 +43,13 @@ jobs: run: bundle config set --local version system - name: bundle install run: | + # TEMP DIAGNOSTIC: print the inherited MAKEFLAGS before clearing it. + echo "DEBUG MAKEFLAGS=[$env:MAKEFLAGS]" + echo "DEBUG MFLAGS=[$env:MFLAGS]" + $env:MAKEFLAGS = '' bundle config set without profilers libs bundle install - name: compile - run: bundle exec rake compile + run: | + $env:MAKEFLAGS = '' + bundle exec rake compile