Add equivalent rules for DRF (DJ26 and DJ27)#148
Open
jvacek wants to merge 5 commits into
Open
Conversation
jvacek
commented
Nov 28, 2024
Comment on lines
+51
to
+52
| | [`DJ26`](https://github.com/rocioar/flake8-django/wiki/%5BDJ26%5D-Do-not-use-exclude-with-ModelSerializer,-use-fields-instead) | Do not use exclude with ModelSerializer, use fields instead | | ||
| | [`DJ27`](https://github.com/rocioar/flake8-django/wiki/%5BDJ27%5D-Do-not-use-__all__-with-ModelSerializer,-use-fields-instead) | Do not use `__all__` with ModelSerializer, use fields instead | |
Author
There was a problem hiding this comment.
This will need to be adjusted ofc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147
Hey @rocioar !
I've implemented the issue I just raised, tried to give the task to Cursor AI and it came up with this solution. Raked over it a bit to fix it up, seems like it's doing what it should.
I made sure to avoid being DRY for the checker file, as these might want to move independently.
Let me know what you think :)