Broken on v4.5

[CallMeBruce]

Love the theme, but it has stopped working on the new v4.5 of qBit, any chance of a fix?

[AngusNB]

A partial screenshot.

[CallMeBruce]

Seems this is by design qbittorrent/qBittorrent#17616 (comment) . This issue qbittorrent/qBittorrent#18109 (comment) recommends using some regex to fix up strings, but as mentioned in that, it doesn't fix all.

[shummo]

I have the same bug...

[mudfinger]

+1

[KarlOfDuty]

+1

[CallMeBruce]

Was able to fix this by downloading the current web ui, running the regex's to remove the language translation string placeholders and re-applying the custom stylesheets from the theme. All working after that.

[KarlOfDuty]

Was able to fix this by downloading the current web ui, running the regex's to remove the language translation string placeholders and re-applying the custom stylesheets from the theme. All working after that.

Could you fork the repo and make a PR with the fix?

[CallMeBruce]

Here is the fork, https://github.com/CallMeBruce/nightwalker, not sure about a PR, there is probably some content that doesn't need to be there and I just did a rush job.

[KarlOfDuty]

Thanks!

[td001]

I'm using @CallMeBruce fork at the moment but will this be fixed soon?

[scottfurry]

As noted upstream in my qbittorrent issue #18602, problem is persistent. It was originally observed in another issue report, qbittorrent issue #18109. However, after some snark from qBT developers, the problem is unresolved and without steps to diagnosis/resolve.

Last night, I make a diff of @CallMeBruce repo and this repo.

I suspect @CallMeBruce had CSS and JS code formatters in use. This made generating a diff a touch more difficult as spacing and tag ordering conflated any repo diff.

Also when generating the diff, I made a conscious choice to NOT touch the JS code in this repo. I suspect that @CallMeBruce employs a javascript linter. This highlighted a few instances where there were missing semicolons in this repo. I'll make a separate pull for others to examine.

Also of note in generating the diff was that @CallMeBruce repo updated dependent JS libraries. I am not conversant in JS, these kinds of changes would require others to consider.

I found a couple of image file issues (file in private/images but not public/images and vice versa - eg: qbittorrent32.png) in this repo. I'm still trying to track down source of a couple of other instances where I encountered missing images before making a PR.

Overall, just stripping out QBT_TR references in the HTML pages did not work for me. I suspect that there are other changes in the JS that need to be performed.

[scottfurry]

Backing away from commitment to PR semicolon changes. Linting of folder produces overwhelming results. Not being versed in nodejs is beyond current capabilities.

Sad really. This is a very useful theme.

FWIW, duplicate icon folder in [project_root]/private/icons

[C8opmBM]

Thanks @CallMeBruce - working nicely :)

[RolandWH]

Thank you very much @CallMeBruce :)