diff --git a/docs/development/v3-editor-handoff-2.md b/docs/development/v3-editor-handoff-2.md index 9870f56..70c9f10 100644 --- a/docs/development/v3-editor-handoff-2.md +++ b/docs/development/v3-editor-handoff-2.md @@ -1,8 +1,8 @@ # v3 Experiment Designer — Handoff for Next Session (Round 2) **Last updated:** 2026-05-29 -**State:** everything below is **merged to `main`** — nothing pending. -**Editor version:** v3 Experiment Designer **v0.12** +**State:** v0.13 = manual-testing fixes (toolbar reflow + editable settings), on a branch → PR. +**Editor version:** v3 Experiment Designer **v0.13** **`main` HEAD:** `7b9e72e` (#78) — prior `9dca364` (#77) **Pinned upstream:** maDisplayTools `origin/version3` at `649d7ef` @@ -88,9 +88,28 @@ passthrough; 10 demo fixtures), **plus**: errors) and an "Export anyway" escape hatch. Soft warnings stay non-blocking. - **Reset button** — clears to the blank skeleton; reversible (one Undo restores). - **Library-row delete (✕)** — blocked while a condition is in use. +- **Toolbar no longer reflows on first edit (v0.13 fix).** The `● edited` + badge moved to the LEFT cluster (before the flex spacer). Previously it sat + among the action buttons and `display:none→inline-block` shoved Undo/Redo/ + **Reset** ~83px left on the first edit, so a click on Reset after editing + missed it — the "create-anchor then Reset both fail" report. Both features + always worked; the clicks were landing on shifted-away buttons. +- **Editable Settings (v0.13).** Experiment Info (name/date_created/author/ + pattern_library) and the Rig path are editable text fields (`docSet` on + `['experiment_info', k]` / `['rig']`; blank info fields `docDelete`). Rig has + a **Browse…** helper that fills in the picked filename while preserving the + directory prefix — browsers can't read full filesystem paths, so the path is + ultimately text. **Plugins stay read-only**: per the v3 spec the protocol's + `plugins:` list is self-contained and the rig is a separate file MATLAB loads, + which the web tool can't read off disk (no rig-plugin inheritance in-tool). ### Known by-design constraints (not gaps) +- **Plugins are not editable in-tool / not inherited from the rig file.** The + rig path is a string MATLAB resolves; the browser has no access to that file. + Editing plugin entries is a YAML-by-hand task (or a future cross-file feature + like D4). + - Complex anchors (map/seq, merge keys `<<: *foo`) are read-only in the UI. - Randomized blocks show a *sample* order in the timeline, labeled "randomized." - Validation **line numbers** cover anchor errors only — structural errors diff --git a/experiment_designer_v3.html b/experiment_designer_v3.html index 3b94775..ff0608e 100644 --- a/experiment_designer_v3.html +++ b/experiment_designer_v3.html @@ -176,6 +176,39 @@ } .settings-section .kv .k { color: var(--text-dim); } .settings-section .kv .v { color: var(--text); word-break: break-all; } + /* Editable settings rows (experiment info, rig) */ + .settings-section .set-row { margin-bottom: 0.45rem; } + .settings-section .set-row label { + display: block; + color: var(--text-dim); + font-size: 0.7rem; + margin-bottom: 0.1rem; + } + .settings-section .set-row input.settings-input { + background: var(--bg); + border: 1px solid var(--border); + color: var(--text); + font-family: 'IBM Plex Mono', monospace; + font-size: 0.75rem; + padding: 0.2rem 0.4rem; + border-radius: 2px; + width: 100%; + box-sizing: border-box; + } + .settings-section .set-row input.settings-input:focus { outline: none; border-color: var(--accent); } + .settings-section .set-row .rig-row { display: flex; gap: 0.3rem; align-items: stretch; } + .settings-section .settings-browse-btn { + background: var(--surface-2); + border: 1px solid var(--border); + color: var(--text-dim); + font-family: inherit; + font-size: 0.7rem; + padding: 0.2rem 0.5rem; + border-radius: 3px; + cursor: pointer; + white-space: nowrap; + } + .settings-section .settings-browse-btn:hover { color: var(--accent); border-color: var(--accent); } .vars-table { width: 100%; font-size: 0.75rem; @@ -1051,11 +1084,16 @@