Skip to content

I18n support#27

Open
luis-mendo wants to merge 10 commits into
refinery:masterfrom
simplelogica:i18n-support
Open

I18n support#27
luis-mendo wants to merge 10 commits into
refinery:masterfrom
simplelogica:i18n-support

Conversation

@luis-mendo

Copy link
Copy Markdown

Adding I18n support.

@jurriaan

jurriaan commented Jul 8, 2013

Copy link
Copy Markdown

@parndt Do you have an idea when i18n support will be added?

@brenes

brenes commented Jul 8, 2013

Copy link
Copy Markdown

@jurriaan if you are interested we have a fork of this gem with i18n included: https://github.com/simplelogica/refinerycms-calendar

The gem is refinerycms-sl-calendar :)

@simi

simi commented Jul 8, 2013

Copy link
Copy Markdown
Member

@brenes is it backward compatible?

Comment thread Gemfile

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no longer own the repo - this is better as:

gem 'refinerycms-i18n', '~> 2.0.0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, we'll fix it as soon as we can

@parndt

parndt commented Jul 8, 2013

Copy link
Copy Markdown
Member

I don't know whether to merge this or #28 can you all help me out here please?

@jurriaan

jurriaan commented Jul 8, 2013

Copy link
Copy Markdown

This one deals with translation of the event data (title/description etc). I think #28 doesn't

@parndt

parndt commented Jul 8, 2013

Copy link
Copy Markdown
Member

@joemsak any chance that you can you help out here please?

@simi

simi commented Jul 8, 2013

Copy link
Copy Markdown
Member

@parndt be careful for backward compatibility.

@joemsak

joemsak commented Jul 8, 2013

Copy link
Copy Markdown
Contributor

This PR seems much more concentrated to one task..

@joemsak

joemsak commented Jul 8, 2013

Copy link
Copy Markdown
Contributor

Although the other one renames the columns "from" and "to" to start/end_at which is smart too

@brenes

brenes commented Jul 8, 2013

Copy link
Copy Markdown

@simi it should be backwards compatible as we have not modified any test (we only added tests) and in the migration we use the migrate data: true when creating the translation table. When we implemented it we migrate from this gem to this version with no reported problem

@brenes

brenes commented Jul 8, 2013

Copy link
Copy Markdown

@parndt, @joemsak as @jurriaan states the other PR is not about the model translation but texts translation

@brenes

brenes commented Jul 8, 2013

Copy link
Copy Markdown

@joemsak from and to was renamed in PR #38 that has been already merged :)

@parndt

parndt commented Jul 8, 2013

Copy link
Copy Markdown
Member

I think there is some confusion. The PR I merged had starts_at and ends_at. I don't like the pluralisation but that's what we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants