diff --git a/includes/Hooks.php b/includes/Hooks.php index 26c1684..23fce66 100644 --- a/includes/Hooks.php +++ b/includes/Hooks.php @@ -12,20 +12,16 @@ use MediaWiki\Revision\RevisionRecord; use Wikimedia\Rdbms\IConnectionProvider; -class Hooks implements +final class Hooks implements BeforePageDisplayHook, GetMagicVariableIDsHook, PageDeleteCompleteHook, ParserGetVariableValueSwitchHook { - private $connectionProvider; - public function __construct( - IConnectionProvider $connectionProvider - ) { - $this->connectionProvider = $connectionProvider; - } + private IConnectionProvider $connectionProvider + ) {} public function onBeforePageDisplay( $out, $skin ): void { $out->addModules( 'ext.hitcounters2.incrementcounter' ); diff --git a/includes/Installer.php b/includes/Installer.php index 1127b54..7f2bf7c 100644 --- a/includes/Installer.php +++ b/includes/Installer.php @@ -4,7 +4,7 @@ use MediaWiki\Installer\Hook\LoadExtensionSchemaUpdatesHook; -class Installer implements LoadExtensionSchemaUpdatesHook { +final class Installer implements LoadExtensionSchemaUpdatesHook { public function onLoadExtensionSchemaUpdates( $updater ) { $dbType = $updater->getDB()->getType(); diff --git a/includes/Rest/Handler/RestIncrementCounter.php b/includes/Rest/Handler/RestIncrementCounter.php index 30f5044..b74a6d2 100644 --- a/includes/Rest/Handler/RestIncrementCounter.php +++ b/includes/Rest/Handler/RestIncrementCounter.php @@ -10,23 +10,16 @@ use Wikimedia\ParamValidator\ParamValidator; use Wikimedia\Rdbms\IConnectionProvider; -/* +/** * Increments the hit counter for the specified page ID * POST /hitcounters2/v0/increment/{id} */ -class RestIncrementCounter extends SimpleHandler { - - private $connectionProvider; - - private $wikiPageFactory; +final class RestIncrementCounter extends SimpleHandler { public function __construct( - IConnectionProvider $connectionProvider, - WikiPageFactory $wikiPageFactory - ) { - $this->connectionProvider = $connectionProvider; - $this->wikiPageFactory = $wikiPageFactory; - } + private IConnectionProvider $connectionProvider, + private WikiPageFactory $wikiPageFactory + ) {} public function run( int $pageID ) { $body = $this->getValidatedBody(); diff --git a/includes/Specials/SpecialResetHitCounter.php b/includes/Specials/SpecialResetHitCounter.php index a44596f..0ed13dc 100644 --- a/includes/Specials/SpecialResetHitCounter.php +++ b/includes/Specials/SpecialResetHitCounter.php @@ -7,16 +7,13 @@ use MediaWiki\Title\Title; use Wikimedia\Rdbms\IConnectionProvider; -class SpecialResetHitCounter extends FormSpecialPage { - - private $connectionProvider; +final class SpecialResetHitCounter extends FormSpecialPage { private $page; public function __construct( - IConnectionProvider $connectionProvider + private IConnectionProvider $connectionProvider ) { - $this->connectionProvider = $connectionProvider; parent::__construct( 'ResetHitCounter', 'hitcounters2-resetcounter' ); }