Correctly synchronise access to WebSocketDelegate#52264
Closed
motiz88 wants to merge 2 commits into
Closed
Conversation
Summary: Changelog: [Internal] Adds a bare-bones API to set the dev server host and port at the time of creating a `ReactInstance` in the C++ platform. Differential Revision: D77050457
Differential Revision: D77150289
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77150289 |
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
Stale
Collaborator
|
Closing as this has been merged in 0031377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D77150289
Fixes a thread safety bug in the C++ platform's
InspectorPackagerConnectionDelegate::WebSocketimplementation. Since #45849IWebSocketDelegateevent calls have been required to be made on the inspector thread, but the C++ platform was making them on the platform's WebSocket thread instead.