RCTTextLayoutManager: Migrate off screen scale access#50407
Closed
RSNara wants to merge 3 commits into
Closed
Conversation
Summary: Let's move the RCTScreenSize and RCTScreenScale calls to the ui thread. That way, these methods don't do an unsafe sync dispatch to the ui thread, which could deadlock react native. In the future, once all call-sites are migrated to the ui thread, we will just make these methods assert that they're being called from the ui thread. Changelog: [Internal] Differential Revision: D72177191
Summary: Let's move the RCTScreenSize and RCTScreenScale calls to the ui thread. That way, these methods don't do an unsafe sync dispatch to the ui thread, which could deadlock react native. In the future, once all call-sites are migrated to the ui thread, we will just make these methods assert that they're being called from the ui thread. Changelog: [Internal] Differential Revision: D72177194
Summary: Let's move the RCTScreenSize and RCTScreenScale calls to the ui thread. That way, these methods don't do an unsafe sync dispatch to the ui thread, which could deadlock react native. In the future, once all call-sites are migrated to the ui thread, we will just make these methods assert that they're being called from the ui thread. Changelog: [Internal] Differential Revision: D72177192
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72177192 |
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
Stale
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
Stale
Collaborator
|
Closing as this has been merged in 61bd649 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Let's move the RCTScreenSize and RCTScreenScale calls to the ui thread.
That way, these methods don't do an unsafe sync dispatch to the ui thread, which could deadlock react native.
In the future, once all call-sites are migrated to the ui thread, we will just make these methods assert that they're being called from the ui thread.
Changelog: [Internal]
Differential Revision: D72177192