From 6ae85f4eda0538966de7942611797afaa8e49c22 Mon Sep 17 00:00:00 2001 From: Aravindan NC <35158113+AravindanNC@users.noreply.github.com> Date: Thu, 29 May 2025 15:38:03 -0400 Subject: [PATCH 1/3] DELIA-68076: RRD Various commands getting "failed because the control process exited with error code." (#134) * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c * Update rrdRunCmdThread.c --- src/rrdRunCmdThread.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/rrdRunCmdThread.c b/src/rrdRunCmdThread.c index e8de08c29..7aff4e4a0 100644 --- a/src/rrdRunCmdThread.c +++ b/src/rrdRunCmdThread.c @@ -380,7 +380,7 @@ bool executeCommands(issueData *cmdinfo) removeQuotes(cmdData->command); - FILE *systemdfp = v_secure_popen("r", "systemd-run -r --unit=%s --service-type=oneshot /bin/sh -c %s", remoteDebuggerServiceStr, cmdData->command); + FILE *systemdfp = v_secure_popen("r", "systemd-run -r --unit=%s --service-type=oneshot -p RemainAfterExit=yes /bin/sh -c %s", remoteDebuggerServiceStr, cmdData->command); if(systemdfp == NULL) { RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,cmdData->rfcvalue); @@ -417,7 +417,6 @@ bool executeCommands(issueData *cmdinfo) /*Stop or Reset runtime service for issue*/ RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Stopping remote_debugger_%s service...\n",__FUNCTION__,__LINE__,cmdData->rfcvalue); v_secure_system("systemctl stop %s", remoteDebuggerServiceStr); - v_secure_system("systemctl reset-failed %s", remoteDebuggerServiceStr); free(cmdData->rfcvalue); // free rfcvalue received from RRDEventThreadFunc free(cmdData->command); // free updated command info received from RRDEventThreadFunc free(cmdData); From 778c4c10741f360393168a8c9e3e80230527456c Mon Sep 17 00:00:00 2001 From: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com> Date: Wed, 25 Jun 2025 20:04:11 +0530 Subject: [PATCH 2/3] DELIA-68122 - RRD device stopped running RRD commands, logs show no progress (#136) * Update rrdInterface.c * Update rrdInterface.c * Update rrdInterface.c --- src/rrdInterface.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/rrdInterface.c b/src/rrdInterface.c index 279d64f49..0aea9b612 100644 --- a/src/rrdInterface.c +++ b/src/rrdInterface.c @@ -318,13 +318,15 @@ void _remoteDebuggerEventHandler(rbusHandle_t handle, rbusEvent_t const* event, return; } - int len = strlen(rbusValue_GetString(value, NULL)); - dataMsg = (char*) rbusValue_GetString(value, NULL); + int len = strlen(rbusValue_GetString(value, NULL))+1; + dataMsg = (char *) calloc(1, len); if(!dataMsg) { - RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Returning dataMsg being NULL \n", __FUNCTION__, __LINE__); + RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Memory Allocation Failed for %s \n", __FUNCTION__, __LINE__, rbusValue_ToString(value, NULL, 0)); return; } + strncpy(dataMsg, rbusValue_GetString(value, NULL), len-1); + dataMsg[len-1]='\0'; if (dataMsg[0] == '\0' || len <= 0 ) { RDK_LOG(RDK_LOG_DEBUG,LOG_REMDEBUG,"[%s:%d]: Message Received is empty, Exit Processing!!! \n", __FUNCTION__, __LINE__); From 84074baeadaaf5c7b37bce296cae21d2f38f57a8 Mon Sep 17 00:00:00 2001 From: nhanasi Date: Mon, 30 Jun 2025 15:01:43 +0000 Subject: [PATCH 3/3] 1.2.8 release changelog updates --- CHANGELOG.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e04d81af..6215898a2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,13 +4,22 @@ All notable changes to this project will be documented in this file. Dates are d Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). +#### [1.2.8](https://github.com/rdkcentral/remote_debugger/compare/1.2.7...1.2.8) + +- DELIA-68122 - RRD device stopped running RRD commands, logs show no progress [`#136`](https://github.com/rdkcentral/remote_debugger/pull/136) +- DELIA-68076: RRD Various commands getting "failed because the control process exited with error code." [`#134`](https://github.com/rdkcentral/remote_debugger/pull/134) +- Merge tag '1.2.7' into develop [`37a89a1`](https://github.com/rdkcentral/remote_debugger/commit/37a89a12e83462bc5e2c36e677d7f3ebab32c200) + #### [1.2.7](https://github.com/rdkcentral/remote_debugger/compare/1.2.6...1.2.7) +> 19 May 2025 + - [DELIA-68036] RRD failing in device for some commands, getting invalid message type (SCXI11BEI) [`#121`](https://github.com/rdkcentral/remote_debugger/pull/121) - RDKEMW-3380 : Evaluate the Deepsleep Scenario for Static and Dynamic method [`#125`](https://github.com/rdkcentral/remote_debugger/pull/125) - Revert " RDK-56291 L2 Tests And Integration With CI for Remote Debugger Dynam…" [`#126`](https://github.com/rdkcentral/remote_debugger/pull/126) - RDKEMW-3380 : Evaluate the Deepsleep Scenario for Static and Dynamic method [`#123`](https://github.com/rdkcentral/remote_debugger/pull/123) - RDK-56291 L2 Tests And Integration With CI for Remote Debugger Dynamic Updates [`#117`](https://github.com/rdkcentral/remote_debugger/pull/117) +- 1.2.7 release changelog updates [`d893197`](https://github.com/rdkcentral/remote_debugger/commit/d893197f25f8f2f27394e1d757669000c38b1068) - Merge tag '1.2.6' into develop [`81ef88a`](https://github.com/rdkcentral/remote_debugger/commit/81ef88a4171be7188d4fd72dfecd4fc9b48288dc) #### [1.2.6](https://github.com/rdkcentral/remote_debugger/compare/1.2.5...1.2.6)