From 4fa4d3ba3924bebfcd1363771b54814cad68e4ad Mon Sep 17 00:00:00 2001 From: Rajeev Katta Date: Tue, 2 Dec 2025 12:46:33 -0500 Subject: [PATCH] rbus: fixup reverse null check in rtMessage_Retain_test1 Coverity issue ID: 139 (REVERSE_INULL) Fix generated by RDKDevPilot AI Bot following pattern from PR #382 The code was checking if msg is NULL after already dereferencing it in rtMessage_Retain(msg). This is a logic error - if msg was NULL, it would crash before reaching the NULL check. Fix: Removed redundant NULL check since rtMessage_Create() guarantees msg is non-NULL or the test would fail earlier. Co-authored-by: rdkdevpilot --- unittests/rbus_unit_test_server.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unittests/rbus_unit_test_server.cpp b/unittests/rbus_unit_test_server.cpp index 9af402d6..6e2ce552 100644 --- a/unittests/rbus_unit_test_server.cpp +++ b/unittests/rbus_unit_test_server.cpp @@ -1308,6 +1308,7 @@ TEST_F(TestServer, rtmsg_rtMessage_SetMessage_test3) rtMessage_Release(item); } + TEST_F(TestServer, rtmsg_rtMessage_Retain_test1) { rtError err; @@ -1317,8 +1318,7 @@ TEST_F(TestServer, rtmsg_rtMessage_Retain_test1) err = rtMessage_Retain(msg); EXPECT_EQ(err, RT_OK); rtMessage_Release(msg); - if(msg) - rtMessage_Release(msg); + rtMessage_Release(msg); } TEST_F(TestServer, rtmsg_rtMessage_Clone_test1)