Shell compatibility for barton-matter - #53
Merged
Conversation
Barton-matter heavily depends on bash syntax, but yocto will just invoke `sh` for shell scripts. This could be non-bash shells. This commit attempts to make barton-matter more compatibile with non-bash shells. Change-Id: Idbda24886b5709c066a358b13e54d98a0c419b46
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make the barton-matter Yocto recipe more compatible with non-bash /bin/sh execution by avoiding direct source of bash-only environment scripts and instead running them in a bash subprocess while importing resulting environment changes back into the task shell.
Changes:
- Bumped the recipe revision (
PR) fromr0tor1. - Added a
_matter_source_bash_env()helper to source bash-only scripts underbashand propagate environment variable changes. - Switched
do_configure:prepend()anddo_compile:prepend()fromsource ./scripts/*.shto_matter_source_bash_env ./scripts/*.sh.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kfundecmcsa
previously approved these changes
Jun 3, 2026
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tleacmcsa
previously approved these changes
Jun 3, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tleacmcsa
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Barton-matter heavily depends on bash syntax, but yocto will just invoke
shfor shell scripts. This could be non-bash shells. This commit attempts to make barton-matter more compatibile with non-bash shells.