From 0384e42c8f2d16b1a7b71d4b6cac0fd039a46865 Mon Sep 17 00:00:00 2001 From: balaji velmurugan Date: Thu, 30 Jul 2026 19:38:11 +0530 Subject: [PATCH 1/2] RDKEMW-22730 : Fix coverity issue on devicesettings Reason for change: Fixing coverity reported issues. Test Procedure: Refer ticket. Risks: Low Priority: P2 version: minor Signed-off-by: balaji velmurugan --- ds/include/audioStereoMode.hpp | 3 +++ rpc/srv/dsAudio.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ds/include/audioStereoMode.hpp b/ds/include/audioStereoMode.hpp index 8b7538c3..6c1fa282 100644 --- a/ds/include/audioStereoMode.hpp +++ b/ds/include/audioStereoMode.hpp @@ -65,6 +65,9 @@ class AudioStereoMode : public DSConstant { AudioStereoMode(int id); virtual ~AudioStereoMode(); + //coverity fix: MISSING_MOVE_ASSIGNMENT - add move operations + AudioStereoMode(AudioStereoMode&&) = default; + AudioStereoMode& operator=(AudioStereoMode&&) = default; }; diff --git a/rpc/srv/dsAudio.c b/rpc/srv/dsAudio.c index 3201175c..00beeb04 100755 --- a/rpc/srv/dsAudio.c +++ b/rpc/srv/dsAudio.c @@ -1507,7 +1507,7 @@ void AudioConfigInit() _DolbyVolumeMode = device::HostPersistence::getInstance().getDefaultProperty("audio.DolbyVolumeMode"); } catch(...) { - _DolbyVolumeMode = "FALSE"; + //coverity fix: UNUSED_VALUE - removed redundant assignment, already initialized to "FALSE" at line 1498 } } if (_DolbyVolumeMode == "TRUE") { From 772166dc859b56a3267e2aa25d3ac9a3ba762fc2 Mon Sep 17 00:00:00 2001 From: balav08 <54432605+balav08@users.noreply.github.com> Date: Mon, 3 Aug 2026 11:44:17 +0530 Subject: [PATCH 2/2] RDKEMW-22730 : Update audioStereoMode.hpp --- ds/include/audioStereoMode.hpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/ds/include/audioStereoMode.hpp b/ds/include/audioStereoMode.hpp index 6c1fa282..8b7538c3 100644 --- a/ds/include/audioStereoMode.hpp +++ b/ds/include/audioStereoMode.hpp @@ -65,9 +65,6 @@ class AudioStereoMode : public DSConstant { AudioStereoMode(int id); virtual ~AudioStereoMode(); - //coverity fix: MISSING_MOVE_ASSIGNMENT - add move operations - AudioStereoMode(AudioStereoMode&&) = default; - AudioStereoMode& operator=(AudioStereoMode&&) = default; };