RDKEMW-17187 : BLE network setting incorrect stream end type - #203
Merged
egalla204 merged 1 commit intoApr 21, 2026
Merged
Conversation
…ore mic key release
There was a problem hiding this comment.
Pull request overview
Adjusts BLE controller voice streaming end conditions to better support “Press and Release” (PAR) voice sessions, addressing premature voice session termination behavior around mic key release.
Changes:
- Inverts the
getPressAndHoldSupport()condition so PAR sessions end audio streaming based on audio duration rather than key-up. - Adds an inline comment clarifying the intended PAR behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
approved for test |
dwolaver
changed the title
egalla204
approved these changes
Apr 21, 2026
egalla204
deleted the
feature/RDKEMW-17187_audio_stop_before_key_release
branch
April 21, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ccp.sys.comcast.net/browse/RDKEMW-17187