From f74cd18ee256a3858a0c0601b960b4a98c59cedd Mon Sep 17 00:00:00 2001 From: Nicholas Tierney Date: Mon, 6 Jul 2026 16:23:40 +1000 Subject: [PATCH 1/4] removes smart quotes for favicon in inst/BS5/templates/head.html Resolves #3005 --- inst/BS5/templates/head.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inst/BS5/templates/head.html b/inst/BS5/templates/head.html index f0578cdb2..e63b668bf 100644 --- a/inst/BS5/templates/head.html +++ b/inst/BS5/templates/head.html @@ -6,7 +6,7 @@ {{#has_favicons}} - + From 8015a4127ab03ffca4812760b4279ac8d67d3073 Mon Sep 17 00:00:00 2001 From: Nicholas Tierney Date: Thu, 9 Jul 2026 09:23:40 +1000 Subject: [PATCH 2/4] Also fix smart quote in bs3 template --- inst/BS3/templates/head.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inst/BS3/templates/head.html b/inst/BS3/templates/head.html index 70037b385..e61bc7058 100644 --- a/inst/BS3/templates/head.html +++ b/inst/BS3/templates/head.html @@ -7,7 +7,7 @@ {{#has_favicons}} - + From 076cfb1702d6e6cf3ecb69817ad482352b5ebb00 Mon Sep 17 00:00:00 2001 From: Nicholas Tierney Date: Thu, 9 Jul 2026 09:27:13 +1000 Subject: [PATCH 3/4] NEWS bump --- NEWS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.md b/NEWS.md index bb0b748e5..d4bd7c14c 100644 --- a/NEWS.md +++ b/NEWS.md @@ -5,6 +5,7 @@ * Test fix for `R CMD check`. * When previewing a site, it is now served via a local http server. This enables dynamic features such as search to work correctly (@shikokuchuo, #2975). * Code in a link (href) is no longer autolinked (#2972) +* Ensure SVG favicons are parsed properly by fixing a bug in BS5 and BS3 favicon icon templates where curly/smart quotes (”…”, U+201D) were used instead of straight quotes, which caused the SVG favicon to not be used and a fallback raster favicon to be used. If your fallback was low resolution, your favicon looked poor. # pkgdown 2.2.0 From 87f7d53339e4f99687918263ccb43feca9f3fc61 Mon Sep 17 00:00:00 2001 From: Nicholas Tierney Date: Thu, 9 Jul 2026 09:27:52 +1000 Subject: [PATCH 4/4] add user and issue number for news bump --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index d4bd7c14c..be0180154 100644 --- a/NEWS.md +++ b/NEWS.md @@ -5,7 +5,7 @@ * Test fix for `R CMD check`. * When previewing a site, it is now served via a local http server. This enables dynamic features such as search to work correctly (@shikokuchuo, #2975). * Code in a link (href) is no longer autolinked (#2972) -* Ensure SVG favicons are parsed properly by fixing a bug in BS5 and BS3 favicon icon templates where curly/smart quotes (”…”, U+201D) were used instead of straight quotes, which caused the SVG favicon to not be used and a fallback raster favicon to be used. If your fallback was low resolution, your favicon looked poor. +* Ensure SVG favicons are parsed properly by fixing a bug in BS5 and BS3 favicon icon templates where curly/smart quotes (”…”, U+201D) were used instead of straight quotes, which caused the SVG favicon to not be used and a fallback raster favicon to be used. If your fallback was low resolution, your favicon looked poor (@njtierney, #3005). # pkgdown 2.2.0