integrate `Eclipse Formatter Profile` into `Maven Spotless Plugin`

[Pankraz76]

Description

After accidentally discovering an existing formatting plugin, I was surprised not to have encountered it while working with the codebase. Maven stands out as the first project to implement this correctly, integrating full auto-fix capabilities into the build process to boost productivity.

However, the presence of unused imports suggests a gap in the current setup, which fails to prevent such issues.

Spotless provides seamless integration with an Eclipse Formatter Profile, making it the ideal solution. It fully automates manual formatting steps, ensuring consistent and correct code style.

Could Quarkus also benefit from automating these standards, which align with the goals of the Eclipse Formatter Profile? Spotless offers an easy way to fix recurring issues, making it a strong candidate for integration.

Implementation ideas

• https://www.baeldung.com/java-maven-spotless-plugin
• https://www.baeldung.com/java-maven-spotless-plugin#custom-formatting-rules
• PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin #48041
• ArrayIndexOutOfBoundsException: Index 570 out of bounds for length 570 diffplug/spotless#2491
• PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin checkstyle/checkstyle#17140
• integrate Eclipse Formatter Profile into Maven Spotless Plugin #48047
• https://github.com/apache/maven-parent/blob/237aabdc41f90c7de15ebaafa27643ed80e5f4da/pom.xml#L1208
• Avoid wildcard * import #45599
• Add editorconfig-maven-plugin #45651
• chore: Never use wildcard imports #45372

[quarkus-bot]

/cc @quarkusio/devtools (maven)

[Pankraz76]

there is already format and validate profile. was not aware of it im sorry.

[Pankraz76]

the only benefit not is the removeUnusedImports feature and the capability to trade 2 for 1 plugin having same bang but with less effort.

[Pankraz76]

this is big change dev team has to demand.

[melloware]

I think it's safe to close this ticket as the dev team has given their feedback on the PR right?

[gastaldi]

Sorry @Pankraz76. I understand you want to improve the code, but please avoid creating any PRs changing the plugins used before discussing in GitHub Discussions because that introduces a maintenance burden on us and wastes your (and our) time on something that could be useful. How about sending a PR fixing issues that already exist in our tracker?

I'm closing this for now. Thanks

[Pankraz76]

Agreed.

We need to start this discussion since the development team may not be aware that potentially 90% of Quarkus (code) seems obsolete, as evidenced by:

• Drop unused members of DefaultAccessLogReceiver #48449

• Fix divider in rotated access log for DefaultAccessLogReceiver #48398

This is the consequence of lacking discipline, which is actively degrading quality.

[Pankraz76]

the dev team

does this code belong exclusively to anyone, or is this open source?

[Pankraz76]

wastes your

learning every time. Looking every time into DefaultAccessLogReceiver seeing something new impossible to have ever been executed. Im constantly learning, all the time.

• maintenance burden #48471