Skip to content

Problems encountered during JOSS review #30

Description

@siboles

@Kev1CO congratulations on this impressive work.

When trying to run the examples, I encountered a few issues:

  • get_cmap has been moved from matplotlib.cm to matplotlib.pyplot since version 3.8.0. This was a problem in bioptim and pyorerun
  • please add scikit-optimize to your environment.yml
  • examples/fes_multibody/cycling/cycling_bayesian_mhe.py fails due to missing the result/initial_guess pickle files
  • If you could add a pyproject.toml file to the project root it would make installation easier. I did this locally and did a pip install -e ., because I encountered some relative pathing issues when running from the examples directory.
  • Finally, it's pretty straight-forward to run the examples, but a short section demonstrating execution of just one example would be helpful.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions