From 2d748f07145d423a2de398f2898003a401062b64 Mon Sep 17 00:00:00 2001 From: Charles Korn Date: Mon, 15 Sep 2025 11:09:26 +1000 Subject: [PATCH] Change `label_replace` and `label_join` test cases to fail when either legacy or UTF-8 name validation is enabled Signed-off-by: Charles Korn --- promql/promql-test-queries.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/promql/promql-test-queries.yml b/promql/promql-test-queries.yml index be3053d3..01c30fa2 100644 --- a/promql/promql-test-queries.yml +++ b/promql/promql-test-queries.yml @@ -199,7 +199,7 @@ test_cases: - query: 'label_replace(demo_num_cpus, "job", "value-$1", "src", "(.*")' should_fail: true # label_replace fails when the destination label name is not a valid Prometheus label name. - - query: 'label_replace(demo_num_cpus, "~invalid", "", "src", "(.*)")' + - query: 'label_replace(demo_num_cpus, "\xff", "", "src", "(.*)")' should_fail: true # label_replace fails when there would be duplicated identical output label sets. - query: 'label_replace(demo_num_cpus, "instance", "", "", "")' @@ -207,7 +207,7 @@ test_cases: - query: 'label_join(demo_num_cpus, "new_label", "-", "instance", "job")' - query: 'label_join(demo_num_cpus, "job", "-", "instance", "job")' - query: 'label_join(demo_num_cpus, "job", "-", "instance")' - - query: 'label_join(demo_num_cpus, "~invalid", "-", "instance")' + - query: 'label_join(demo_num_cpus, "\xff", "-", "instance")' should_fail: true - query: '{{.dateFunc}}()' variant_args: ['dateFunc']