Hi team 👋
Before #194, remotewrite/sender registered otel, telegraf, etc, targets and ran TestRemoteWrite/<target>/<case> against each. After #194 only prometheus is registered, targets/otel.go and the other non-Prometheus target files are gone, cases/ is removed, and the compliance build tag is no longer used.
This breaks the workflow in opentelemetry-collector-contrib that runs the following command against this repo and the selector now matches nothing:
go test -v --tags=compliance -run "TestRemoteWrite/otel/.+" ./
We've been working around it by pinning to adfa690dd4df11f9c1bc1b130db5843fdca219f1.
Relates to open-telemetry/opentelemetry-collector-contrib#45353
Two questions:
- Was removing the non-Prometheus targets intentional?
- If yes, would you accept a PR adding
targets/otel.go back and wiring it into the new RW2 tests, so the OTel Collector's prometheusremotewrite exporter can be exercised again?
Hi team 👋
Before #194,
remotewrite/senderregisteredotel,telegraf, etc, targets and ranTestRemoteWrite/<target>/<case>against each. After #194 onlyprometheusis registered,targets/otel.goand the other non-Prometheus target files are gone,cases/is removed, and thecompliancebuild tag is no longer used.This breaks the workflow in
opentelemetry-collector-contribthat runs the following command against this repo and the selector now matches nothing:We've been working around it by pinning to
adfa690dd4df11f9c1bc1b130db5843fdca219f1.Relates to open-telemetry/opentelemetry-collector-contrib#45353
Two questions:
targets/otel.goback and wiring it into the new RW2 tests, so the OTel Collector'sprometheusremotewriteexporter can be exercised again?