Skip to content

Fix: corrected etcd multi-cluster dashboard bug - #6367

Open
BahmaniAlireza wants to merge 1 commit into
prometheus-community:mainfrom
BahmaniAlireza:fix-etcd-dashboard-bug
Open

Fix: corrected etcd multi-cluster dashboard bug#6367
BahmaniAlireza wants to merge 1 commit into
prometheus-community:mainfrom
BahmaniAlireza:fix-etcd-dashboard-bug

Conversation

@BahmaniAlireza

Copy link
Copy Markdown

What this PR does / why we need it

This PR fixes the etcd Grafana dashboard shipped with kube-prometheus-stack.
The existing dashboard did not correctly filter by cluster name in multi‑cluster environments, causing metrics from multiple clusters to be aggregated together.

We updated the dashboard definition in templates/grafana/dashboards-1.14/etcd.yaml to add a cluster variable and adjust the PromQL queries. With this change, the dashboard now works correctly when:

  • A single cluster is selected
  • Multiple clusters are selected
  • The “All” option is used

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

  • The change was applied directly to etcd.yaml under dashboards-1.14.
  • Tested locally with Helm upgrade; verified the generated ConfigMap contains the updated JSON.
  • Validated in Grafana that the cluster dropdown now filters metrics correctly.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [kube-prometheus-stack] fix etcd dashboard cluster filter)

@QuentinBisson

Copy link
Copy Markdown
Member

@jkroepke

jkroepke commented Dec 2, 2025

Copy link
Copy Markdown
Member

@QuentinBisson i have the feeling that etcd maintainers dont care about dashboard anymore @TheRealNoob also had conversations with the etcd maintainer. I feel the feeling that we should not longer consume upstream and fork the dashboard into the repo. If you agree, I would appreciate, if you could assists the user here.

@TheRealNoob

Copy link
Copy Markdown
Contributor

so sorry for missing this @ mention

Not too long ago I did go through all the formal conversations about migrating the etcd mixin from etcd-io/etcd to kubernetes-monitoring/kubernetes-mixin. But I kinda burnt myself out with all the waiting and discussions/etc. I'll hop back onto it now to see it through. Thank you for reminding me.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to no activity for 90 days. The label will be removed automatically when new activity occurs.

@TheRealNoob

Copy link
Copy Markdown
Contributor

no stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants