Skip to content

VulkanUtil.CheckResult being marked as Conditonal(DEBUG) is bugprone #61

Description

@neptuwunium

This causes barely traceable segfaults on release builds if any internal vulkan call is invalid (due to invalid arguments) because the result is assumed to be correct.

This was discovered in a downstream consumer of ppy.Veldrid where the X11 window number was zero, resulting in a nullptr surface when calling VkSurfaceUtil.CreateSurface using Xlib surface arguments, and causing a segfault when the surface is used later in the init chain.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions