Fix Sync Streams division by zero semantics#646
Open
sravan27 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 421ae90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a Sync Streams JavaScript evaluator divergence from SQLite around division by zero.
SQLite returns
NULLfor divide-by-zero expressions:5 / 05 / 0.05 / '0'0 / 0The current JavaScript evaluator can instead return
Infinityfor real division by zero or throw for bigint division by zero. In filter expressions this can create evaluator errors or non-SQLite truthiness instead of SQLite'sNULLresult.Changes
nullfrom the shared math operator implementation when the division RHS casts to zero.@powersync/service-sync-rules.Verification