Fix Sync Streams signed string casts#645
Open
sravan27 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: f840f31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Sync Streams expression evaluation for SQLite-style casts from signed numeric strings. The JavaScript evaluator previously parsed only unsigned numeric prefixes, so values like
CAST('-12' AS integer)andCAST('-.5' AS numeric)evaluated as0instead of matching SQLite.Why this matters
Sync rules can cast request parameters or JSON/text values before filtering rows. A signed value in a parameter or source row could therefore select the wrong rows in the JavaScript evaluator compared with SQLite semantics.
Changes
+/-prefixes when parsing integer casts from strings..5/-.5.@powersync/service-sync-rules.Verification
corepack pnpm --dir packages/sync-rules exec vitest test/src/sql_functions.test.ts --runcorepack pnpm --dir packages/sync-rules exec vitest test/src/sync_plan/engine/engine.test.ts --run -t "javascript.*signed string casts|javascript"corepack pnpm --dir packages/sync-rules run build:tscNote: running the full scalar engine test file against local Node v23.7.0 fails in the existing SQLite-engine tests because Node's experimental
node:sqlitereturns object rows instead of the array rows expected by the suite. The JavaScript evaluator path and pure cast tests pass locally.