Skip to content

Added filtering capabilities#6

Open
eliseomartelli wants to merge 1 commit into
postlund:masterfrom
eliseomartelli:filter_domain
Open

Added filtering capabilities#6
eliseomartelli wants to merge 1 commit into
postlund:masterfrom
eliseomartelli:filter_domain

Conversation

@eliseomartelli

Copy link
Copy Markdown

I love your search card so I thought that I may help by adding some domain-filtering capabilities :)

@postlund

Copy link
Copy Markdown
Owner

Great addition, thanks! Was thinking about adding the same thing as well 😊 Added a small comment you can have a look at. Would also like it that you update the readme and extend the example, so people know how to use it.

@eliseomartelli

Copy link
Copy Markdown
Author

I think we can close this 'cause the regex filter already covers this usecase :)

@postlund

Copy link
Copy Markdown
Owner

I still see a valid purpose with this change, as it allows permanent exclusion of results that you might never wanna see.

@KTibow

KTibow commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

Mind resolving the conflicts @eliseomartelli?

@Shaun-Harrison

Copy link
Copy Markdown

Can we get some examples of the regex if this isn't going to be merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants