Skip to content

CLOSE_ISSUES_MANUAL.md

Latest commit

 

History

History
177 lines (120 loc) · 4.74 KB

CLOSE_ISSUES_MANUAL.md

File metadata and controls

177 lines (120 loc) · 4.74 KB

Manual Issue Closing Instructions

Since gh CLI is not installed, here's how to close the issues manually via the GitHub web interface:

🚀 Quick Method (Copy-Paste)

Visit each issue URL and paste the corresponding comment, then click "Close with comment":

#49 - #49

Fixed in commit f04963d.

The argument order has been corrected to match IWYU specification:
- **Before**: `self.run_command([filename] + self.args)` (WRONG)
- **After**: `self.run_command(self.args + [filename])` (CORRECT)

IWYU expects: `<clang opts> <source file>` not `<source file> <clang opts>`

See: hooks/include_what_you_use.py:25-27

#55 - #55

Fixed in commit f04963d.

Two improvements made:
1. Fixed argument order (related to #49)
2. Added explicit failure detection when IWYU doesn't set proper exit code:

```python
if self.returncode == 0:
    # If IWYU didn't set a proper exit code but includes are wrong, force failure
    self.returncode = 1

IWYU will now properly fail when includes are incorrect.

See: hooks/include_what_you_use.py:34-39


---

### #46 - https://github.com/pocc/pre-commit-hooks/issues/46

Fixed in commit fd3ea4a.

The critical logic error has been corrected:

Before (WRONG):

if len(self.stderr) > 0 and "--fix-errors" in self.args:
    self.returncode = 1  # FAILS when --fix-errors IS present ❌

After (CORRECT):

if len(self.stderr) > 0 and "--fix-errors" not in self.args:
    self.returncode = 1  # FAILS when --fix-errors is NOT present ✅

The logic was inverted, causing args to be mishandled. This is now fixed and covered by regression tests.

See: hooks/clang_tidy.py:27 Tests: tests/test_logic_regression.py::TestClangTidyFixErrorsLogic


---

### #61 - https://github.com/pocc/pre-commit-hooks/issues/61

Fixed in commit fd3ea4a.

Both the misleading comment AND the logic error it described have been fixed:

  1. Comment updated: Now correctly describes the behavior
  2. Logic fixed: The inverted condition has been corrected (see #46)

The comment at clang_tidy.py:22 now accurately reflects the actual behavior, and the logic at line 27 has been corrected.

See: hooks/clang_tidy.py:22 and :27 Tests: tests/test_logic_regression.py


---

### #44 - https://github.com/pocc/pre-commit-hooks/issues/44

Likely fixed in commit fd3ea4a.

We've significantly improved version argument parsing in the parse_args() method:

  1. Better handling of --version=X.Y.Z format
  2. Better handling of --version X.Y.Z format
  3. Comprehensive test coverage for version edge cases

The issue described (version checking preventing format checking) should now be resolved. If you can test with your original config and confirm, that would be great!

See: hooks/utils.py parse_args method Tests: tests/test_edge_cases.py::TestArgumentParsing::test_version_with_*


---

### #66 - https://github.com/pocc/pre-commit-hooks/issues/66

Fixed in commit fd3ea4a - and exceeded the request!

Updated to: black==24.10.0 (even newer than the requested 24.3.0) Also updated: pytest from 5.4.1 to 8.3.4

See: requirements.txt


---

### #53 - https://github.com/pocc/pre-commit-hooks/issues/53

Fixed in commit f04963d with updated documentation.

The README now includes explicit instructions for adding LLVM tools to PATH on macOS:

echo 'export PATH="/opt/homebrew/opt/llvm/bin:$PATH"' >> ~/.zshrc

LLVM does include clang-format and clang-tidy, but they may not be automatically added to your PATH after installation. The updated installation instructions now clarify this.

See: README.md Installation section for MacOS


---

## 💬 Comment (Don't Close) on These

### #45 - https://github.com/pocc/pre-commit-hooks/issues/45

Improved in commit f04963d.

Added progress indicator to address the visibility issue:

[OCLint 1/5] Analyzing file1.c
[OCLint 2/5] Analyzing file2.c
...

Regarding multiple execution: This is by design. OCLint runs once per file to provide per-file analysis, which is necessary for accurate results. Each file may have different compilation settings, dependencies, and context.

The progress indicator should make this behavior clearer. Does this address your concerns about output visibility? If you have suggestions for further improvements, please let me know!

See: hooks/oclint.py:36-42


---

## ✅ Checklist

- [ ] Close #49 with comment
- [ ] Close #55 with comment
- [ ] Close #46 with comment
- [ ] Close #61 with comment
- [ ] Close #44 with comment
- [ ] Close #66 with comment
- [ ] Close #53 with comment
- [ ] Comment on #45 (don't close)

---

## 🎯 Result

**Issues Closed**: 7
**Issues Improved**: 1
**Closure Rate**: 50% (7 out of 14 open issues)