From c76f91d4f7bf69ea16c3d3d2b34ba71d16dc6412 Mon Sep 17 00:00:00 2001
From: Jan Mevissen <mevissen@interaktiv.de>
Date: Wed, 22 Apr 2026 13:10:07 +0200
Subject: [PATCH 1/3] jmevissen: fix plone/plone.app.workflow#21 sort only on
 first three entries

---
 src/plone/app/workflow/browser/sharing.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/plone/app/workflow/browser/sharing.py b/src/plone/app/workflow/browser/sharing.py
index ceacc2b..600b5ee 100644
--- a/src/plone/app/workflow/browser/sharing.py
+++ b/src/plone/app/workflow/browser/sharing.py
@@ -285,7 +285,10 @@ def existing_role_settings(self):
             (a["id"] not in self.STICKY, a["type"], a["name"], a)
             for a in items.values()
         ]
-        dec_users.sort()
+        # Sort only on the first three entries,
+        # the fourth is a dict and would raise a TypeError
+        # see plone/plone.app.workflow#21
+        dec_users.sort(key=lambda d: (d[0], d[1], d[2]))
 
         # Add the items to the info dict, assigning full name if possible.
         # Also, recut roles in the format specified in the docstring

From 514c341b92590792b17b4af53bfdba5ca4676f98 Mon Sep 17 00:00:00 2001
From: Jan Mevissen <mevissen@interaktiv.de>
Date: Wed, 22 Apr 2026 14:09:11 +0200
Subject: [PATCH 2/3] jmevissen: fix plone/plone.app.workflow#21 add testing

---
 .../app/workflow/tests/test_sharing_view.py   | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/src/plone/app/workflow/tests/test_sharing_view.py b/src/plone/app/workflow/tests/test_sharing_view.py
index df11b1b..23416e9 100644
--- a/src/plone/app/workflow/tests/test_sharing_view.py
+++ b/src/plone/app/workflow/tests/test_sharing_view.py
@@ -234,3 +234,26 @@ def lrme_handler(context, event):
         # check subscriber called
         self.assertEqual(context.context, context)
         self.assertEqual(context.event, event)
+
+    def test_existing_role_settings_sort_with_duplicate_names(self):
+        """Regression test for plone/plone.app.workflow#21.
+
+        When two entries tie on (sticky, type, name), the old
+        ``dec_users.sort()`` fell through to comparing the item dicts at
+        index 3, raising ``TypeError: '<' not supported between instances
+        of 'dict' and 'dict'`` on Python 3.
+        """
+        login(self.portal, "manager")
+        sharing = getMultiAdapter((self.portal, self.request), name="sharing")
+
+        def fake_inherited_roles():
+            return (
+                ("shared_name", ("Reader",), "user", "user_a"),
+                ("shared_name", ("Reader",), "user", "user_b"),
+            )
+
+        sharing._inherited_roles = fake_inherited_roles
+        info = sharing.existing_role_settings()
+        ids = {entry["id"] for entry in info}
+        self.assertIn("user_a", ids)
+        self.assertIn("user_b", ids)

From 7a9a5828f92884463fa5d5c40fc4148ca6cb319f Mon Sep 17 00:00:00 2001
From: Jan Mevissen <mevissen@interaktiv.de>
Date: Wed, 22 Apr 2026 14:19:34 +0200
Subject: [PATCH 3/3] jmevissen: fix plone/plone.app.workflow#21 add changelog
 note

---
 news/21.bugfix | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 news/21.bugfix

diff --git a/news/21.bugfix b/news/21.bugfix
new file mode 100644
index 0000000..a5e9820
--- /dev/null
+++ b/news/21.bugfix
@@ -0,0 +1,2 @@
+Fix ``TypeError`` in the sharing view when two role entries tie on
+``(sticky, type, name)``; [jmevissen]