Error when using typescript conf with moduleResolution set to bundler

[dducluzeaud]

Hi,

We have recently moved our tsconfig to module: "ESNext" and moduleResolution: "bundler ". Everything was working except betterer due to the incompatily between the module and the moduleResolution. I noticed the tsConfing bein rewriting in the file betterer/config/ register

function registerTypeScript() {
....
 compilerOptions: {
      module: 'commonjs'
    },
...

Is there any reason for that line because if I remove it completely everything works fine. I tried to pass my file to .betterer.js but unfortunately I had the same probleme. A work around was to create a tsconfig.bettterer.json and path it to the cli. I can create a PR if you are interested.

[phenomnomnominal]

Thanks for this! With a few years of hindsight I’ve realised that trying to be too helpful with TypeScript was a mistake, and it’s the main thing that’s preventing me from getting ESM working and blocking the whole project. So I’m in the process of removing the baked-in TS support, which will come soon in V6. I think in 2024 it makes sense for people to manage the TS bit themselves. Hopefully your workaround is good enough for now, I’ll leave this open to keep you updated though.

[dducluzeaud]

Thank you for your response and your work on this library.

The workaround is working correctly so that's good for me and I'm looking forward for the V6 though.