Skip to content

Replace custom NMS with torchvision library implementation #141

Description

@github-actions

Current implementation is custom-written. Consider using official torchvision NMS:
Reference: https://github.com/pytorch/vision/blob/main/torchvision/csrc/ops/cpu/nms_kernel.cpp
Benefits:

  1. Optimized CPU/CUDA implementations available
  2. Better maintained and tested by PyTorch team
  3. Reduces custom code maintenance burden
    Trade-off: Adds torchvision as dependency (currently only use LibTorch)

Line: 114

return y;
}
// TODO: Replace custom NMS with torchvision library implementation
// category=Vision estimate=4h
// Current implementation is custom-written. Consider using official torchvision NMS:
// Reference: https://github.com/pytorch/vision/blob/main/torchvision/csrc/ops/cpu/nms_kernel.cpp
// Benefits:
// 1. Optimized CPU/CUDA implementations available
// 2. Better maintained and tested by PyTorch team
// 3. Reduces custom code maintenance burden

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions