[ENHANCEMENT] add client package#137
Open
shahrokni wants to merge 1 commit into
Open
Conversation
shahrokni
force-pushed
the
feat/create-client
branch
4 times, most recently
from
39f0887 to
b77d72b
Compare
jgbernalp
reviewed
May 22, 2026
jgbernalp
reviewed
May 22, 2026
jgbernalp
reviewed
May 22, 2026
| }, | ||
| }, | ||
| // TODO should we add @perses-dev/spec here ? | ||
| '@perses-dev/core': { |
Contributor
There was a problem hiding this comment.
If we remove this we need to add the client package
Contributor
|
The plugin system has a duplicated definition of the |
jgbernalp
reviewed
May 22, 2026
Contributor
Author
I was aware of that blunder and had planned to get rid of it. Thank you for reminding me. I almost forgot! |
shahrokni
force-pushed
the
feat/create-client
branch
2 times, most recently
from
4df95ba to
8d1d7f0
Compare
jgbernalp
reviewed
May 22, 2026
| '@perses-dev/core': { | ||
| version: '0.53.1', | ||
| lib: () => require('@perses-dev/core'), | ||
| '@perses-dev/client': { |
Contributor
There was a problem hiding this comment.
This would mean this is a breaking change, because the plugin system no longer exposes the core package. It would be better to mark this PR as BREAKINGCHANGE
Contributor
There was a problem hiding this comment.
On second thought maybe it will be better to include both, at least for one version so migration can be done smoothly. WDYT?
shahrokni
force-pushed
the
feat/create-client
branch
from
8d1d7f0 to
6330c8b
Compare
shahrokni
changed the title
shahrokni
changed the title
shahrokni
force-pushed
the
feat/create-client
branch
from
6330c8b to
ac55600
Compare
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
shahrokni
force-pushed
the
feat/create-client
branch
from
ac55600 to
7577657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the client package and removes the remaining core dependencies.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See e2e docs for more details. Common issues include: