From bb80d18853e41a44b9ff6e73bf83f8420f075df4 Mon Sep 17 00:00:00 2001 From: Yulian Lyubomirov Cenov Date: Thu, 28 May 2026 12:24:39 +0200 Subject: [PATCH] Bug fix hazard string to class Signed-off-by: Yulian Lyubomirov Cenov --- src/physrisk/hazard_models/core_hazards.py | 11 +++++++++-- tests/test_base.py | 21 --------------------- 2 files changed, 9 insertions(+), 23 deletions(-) delete mode 100644 tests/test_base.py diff --git a/src/physrisk/hazard_models/core_hazards.py b/src/physrisk/hazard_models/core_hazards.py index 6f52aa1b..5285efae 100644 --- a/src/physrisk/hazard_models/core_hazards.py +++ b/src/physrisk/hazard_models/core_hazards.py @@ -13,7 +13,6 @@ SourcePaths, ) from physrisk.data.inventory import EmbeddedInventory, Inventory -from physrisk.kernel import hazards from physrisk.kernel.hazards import ( ChronicHeat, CoastalInundation, @@ -107,7 +106,15 @@ def all_hazards(self): ) def hazard_types(self): - return [hazards.hazard_class(ht) for ht in self.all_hazards()] + hazard_types = [] + for hazard in self.all_hazards(): + try: + hazard_types.append(hazard_class(hazard)) + except AttributeError: + logger.warning( + f"unable to find hazard class for hazard {hazard}, skipping" + ) + return hazard_types def resource_paths( self, diff --git a/tests/test_base.py b/tests/test_base.py deleted file mode 100644 index 5e72175a..00000000 --- a/tests/test_base.py +++ /dev/null @@ -1,21 +0,0 @@ -import os -import pathlib -import shutil -import tempfile -import unittest - -from dotenv import load_dotenv - - -class TestWithCredentials(unittest.TestCase): - """Test that attempts to load contents of credentials.env into environment variables (if present)""" - - def setUp(self): - self.test_dir = tempfile.mkdtemp() - dotenv_dir = os.environ.get("CREDENTIAL_DOTENV_DIR", os.getcwd()) - dotenv_path = pathlib.Path(dotenv_dir) / "credentials.env" - if os.path.exists(dotenv_path): - load_dotenv(dotenv_path=dotenv_path, override=True) - - def tearDown(self): - shutil.rmtree(self.test_dir)