[BUG]: Unblock TranslateWiki PRs

[BenHenning]

Describe the bug

#6036 (comment) has the specific issues, and there are child issues to this one to track. Because of Translatewiki now pulling in Hindi and ES-419 strings there's a bunch of pipeline work we need to do support these.

Besides the child issues, there are 72 lint failures in the strings themselves issues that need to be fixed (as of the latest TranslateWiki CI run relative to this issue being created) are seen here: https://gist.github.com/BenHenning/7213c53fd84d52b06e5cab08af9f42d2.

All lint issues fall into these categories to address:

• IMPLIED_QUANTITY (8/72): All problems in the Hindi translations where the translator didn't actually use a %d qualifier for specifically the "one" plural case despite that matching both 0 and 1 in Hindi. This applies to messages:
  • Hindi: chapter_count
  • Hindi: story_count
  • Hindi: lesson_count
  • Hindi: completed_story_count
  • Hindi: ongoing_topic_count
  • Hindi: minutes_ago
  • Hindi: hours_ago
  • Hindi: days_ago
• STRING_FORMAT_COUNT (4/72): these are Hindi messages that are incorrectly using the type specifiers (e.g. %1$s) and seem to have extra incorrect %s actually. This applies to messages (note that despite there being 4 reported errors they are duplicated so there are only two):
  • Hindi: chapter_completed
  • Hindi: math_expression_error_number_after_var_term
• STRING_FORMAT_INVALID (2/72): this is related to the previous point. The extra % in the following message is causing an issue (and it's being reported as 2 errors for this one message):
  • chapter_completed
• TYPOGRAPHY_DASHES (3/72): these are cases where a hyphen - is being used but an en dash should be used instead in this case since these are all ranges: –. This applies to messages:
  • Spanish: number_error_larger_than_fifteen_characters
  • Hindi: number_error_larger_than_fifteen_characters
  • Hindi: nps_score_question
• TYPOGRAPHY_ELLIPSIS (1/72): this is a case of using ... (three periods) instead of the ellipsis character: …. This affects message:
  • Spanish: no
• TYPOGRAPHY_FRACTIONS (1/72): this is a case of using 1/2 instead of the one half character: ½. This affects message:
  • Spanish: ratio_error_invalid_format
• TYPOGRAPHY_QUOTES (50/72): these are cases where standard quotes " need to be replaced with directional quotes: “” (Unicode: “ and ”). Note that these are tricky to copy or use so care should be taken since smart quotes can sometimes behave a bit unexpectedly in text editors. This affects messages:
  • Spanish: progress_database_full_dialog_description
  • Spanish: math_expression_error_single_redundant_parentheses
  • Spanish: math_expression_error_multiple_redundant_parentheses
  • Spanish: math_expression_error_redundant_parentheses_individual_term
  • Spanish: math_expression_error_unnecessary_symbols
  • Spanish: math_expression_error_missing_lhs_for_addition_operator
  • Spanish: math_expression_error_missing_lhs_for_multiplication_operator
  • Spanish: math_expression_error_missing_lhs_for_division_operator
  • Spanish: math_expression_error_missing_lhs_for_exponentiation_operator
  • Spanish: math_expression_error_missing_rhs_for_addition_operator
  • Spanish: math_expression_error_missing_rhs_for_subtraction_operator
  • Spanish: math_expression_error_missing_rhs_for_multiplication_operator
  • Spanish: math_expression_error_missing_rhs_for_division_operator
  • Spanish: math_expression_error_missing_rhs_for_exponentiation_operator
  • Spanish: math_expression_error_missing_equals
  • Spanish: math_expression_error_more_than_one_equals
  • Spanish: math_expression_error_hanging_equals
  • Spanish: math_expression_error_unsupported_function
  • Spanish: number_error_starting_with_floating_point
  • Spanish: welcome
  • Spanish: privacy_policy_web_link
  • Spanish: agree_to_terms
  • Spanish: terms_of_service_web_link
  • Spanish: faq_answer_whats_oppia
  • Hindi: progress_database_full_dialog_description
  • Hindi: fractions_default_hint_text
  • Hindi: math_expression_error_single_redundant_parentheses
  • Hindi: math_expression_error_multiple_redundant_parentheses
  • Hindi: math_expression_error_redundant_parentheses_individual_term
  • Hindi: math_expression_error_unnecessary_symbols
  • Hindi: math_expression_error_missing_lhs_for_addition_operator
  • Hindi: math_expression_error_missing_lhs_for_multiplication_operator
  • Hindi: math_expression_error_missing_lhs_for_division_operator
  • Hindi: math_expression_error_missing_lhs_for_exponentiation_operator
  • Hindi: math_expression_error_missing_rhs_for_addition_operator
  • Hindi: math_expression_error_missing_rhs_for_subtraction_operator
  • Hindi: math_expression_error_missing_rhs_for_multiplication_operator
  • Hindi: math_expression_error_missing_rhs_for_division_operator
  • Hindi: math_expression_error_missing_rhs_for_exponentiation_operator
  • Hindi: math_expression_error_missing_equals
  • Hindi: math_expression_error_more_than_one_equals
  • Hindi: math_expression_error_hanging_equals
  • Hindi: math_expression_error_unsupported_function
  • Hindi: number_error_starting_with_floating_point
  • Hindi: welcome
  • Hindi: privacy_policy_web_link
  • Hindi: agree_to_terms
  • Hindi: terms_of_service_web_link
  • Hindi: faq_answer_whats_oppia
  • Hindi: faq_answer_whos_an_admin
• TYPOS (3/72): these are specific potential typos discovered by the lint tool:
  • Spanish: math_expression_error_single_redundant_parentheses. Error message: "al rededor" is a common misspelling; did you mean "alrededor"?
  • Spanish: math_expression_error_multiple_redundant_parentheses. Error message: "al rededor" is a common misspelling; did you mean "alrededor"?
  • Spanish: math_expression_error_redundant_parentheses_individual_term. Error message: "al rededor" is a common misspelling; did you mean "alrededor"?

All of these will require changes directly on Translatewiki.

Steps To Reproduce

#6158 isn't passing CI checks.

Expected Behavior

#6158 should pass CI checks and the app should be able to use the new strings.

Screenshots/Videos

No response

What device/emulator are you using?

No response

Which Android version is your device/emulator running?

No response

Which version of the Oppia Android app are you using?

No response

Additional Context

No response

[BenHenning]

I've marked the issues that have been fixed as of the latest push to #6158. There are a few more fixed but I only checked Spanish for now. I haven't checked for any new issues, though Spanish only has the single reported issue above remaining.

[BenHenning]

Thanks to @seanlip most of the remaining Hindi issues were fixed. All that remains are the current unchecked ones. Surprisingly, the error for math_expression_error_number_after_var_term went away even though we're still unsure how to correctly fix the STRING_FORMAT_COUNT/STRING_FORMAT_INVALID issue (specifically for chapter_completed).

[seanlip]

@BenHenning Oh, i misread the chapter_completed one and forgot an extra %, oops. Fixed now!

I think the only remaining ones are the quote marks in HTML. How do you want to handle those? My suggestion would actually be to disable that particular warning since I think it is not correct.