Skip to content

Add tests for PRs #4259 and #4271 #5815

Description

@adhiamboperes

Is your feature request related to a problem? Please describe.

#4259 and #4271 were merged with only the most critical tests due to a time crunch. This issue tracks tests that should be added to increase the coverage.

Describe the solution you'd like

For #4271:

  • AdministratorControlsActivity.kt

  • verify that ProfileAndDeviceId option is displayed in multiplane layouts

  • verify that ProfileAndDeviceId option is displayed in non-multiplane layouts

  • AdministratorControlsFragment.kt

  • Verify the contents of the UI for phone portrait and lanscape, as well as tablet layout

  • AudioFragment.kt

  • Currently exempted from testing

  • A new test suite should be created and the full functionality added

  • ResumeLessonFragmentPresenter.kt
    verify:

  • checkpoint retrieved successfully

  • checkpoint retrieval failed

  • click restart lesson

  • click continue lesson.

  • StoryFragmentPresenter.kt

  • Resuming an in progress chapter(navigate to resume lesson activity)

  • Replaying a completed chapter(navigate to exploration activity)

  • Playing a chapter not started yet(navigate to exploration activity)

  • Verify EventLogs

  • createOpenStoryActivityContext in StoryFragmentPresenter

  • createOpenConceptCardContext in ConceptCardFragmentPresenter.kt

  • createOpenProfileChooserContext in ProfileChooserFragmentPresenter.kt

For #4259:

  • MathExpressionExtensions.kt

  • Add tests for fun MathExpression.stripRedundantGroups(): MathExpression

  • Math expression classifiers
    Add tests for math expression classifiers to verifying that rule inputs can include minor errors (particularly, redundant parentheses).

  • NumericExpressionInputMatchesUpToTrivialManipulationsRuleClassifierProvider.kt

  • NumericExpressionInputMatchesExactlyWithRuleClassifierProvider.kt

  • NumericExpressionInputIsEquivalentToRuleClassifierProvider.kt

  • MathEquationInputMatchesUpToTrivialManipulationsRuleClassifierProvider.kt

  • MathEquationInputMatchesExactlyWithRuleClassifierProvider.kt

  • MathEquationInputIsEquivalentToRuleClassifierProvider.kt

  • AlgebraicExpressionInputMatchesUpToTrivialManipulationsRuleClassifierProvider.kt

  • AlgebraicExpressionInputMatchesExactlyWithRuleClassifierProvider.kt

  • AlgebraicExpressionInputIsEquivalentToRuleClassifierProvider.kt

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

Labels

Impact: LowLow perceived user impact (e.g. edge cases).Work: LowSolution is clear and broken into good-first-issue-sized chunks.enhancementEnd user-perceivable enhancements.good first issueThis item is good for new contributors to make their pull request.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions