From 8a68a38c60c3422426a3aad81bf4b4439ace2515 Mon Sep 17 00:00:00 2001 From: Dan Mace Date: Thu, 2 Jul 2026 16:17:48 -0400 Subject: [PATCH] fix(aws): isolate NewSession tests from ambient AWS env vars Clear AWS_PROFILE and AWS_DEFAULT_PROFILE in test setup so config.LoadDefaultConfig does not pick up the host's profile and fail silently (the error is discarded, producing a zero-value config). Signed-off-by: Dan Mace --- cmd/infra/aws/util/util_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cmd/infra/aws/util/util_test.go b/cmd/infra/aws/util/util_test.go index 50d5607b213a..6cda826d7d21 100644 --- a/cmd/infra/aws/util/util_test.go +++ b/cmd/infra/aws/util/util_test.go @@ -43,7 +43,9 @@ func TestNewSession(t *testing.T) { region: "us-west-2", expectNonNil: true, setupFunc: func(t *testing.T) string { - // Create a temporary credentials file + for _, env := range []string{"AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY", "AWS_SESSION_TOKEN", "AWS_SHARED_CREDENTIALS_FILE", "AWS_CONFIG_FILE", "AWS_PROFILE", "AWS_DEFAULT_PROFILE"} { + t.Setenv(env, "") + } tmpDir := t.TempDir() credsFile := filepath.Join(tmpDir, "credentials") content := `[default] @@ -72,7 +74,7 @@ aws_secret_access_key = test-secret-key expectNonNil: true, setupFunc: func(t *testing.T) string { // Ensure AWS env vars don't shadow the file credentials. - for _, env := range []string{"AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY", "AWS_SESSION_TOKEN", "AWS_SHARED_CREDENTIALS_FILE", "AWS_CONFIG_FILE"} { + for _, env := range []string{"AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY", "AWS_SESSION_TOKEN", "AWS_SHARED_CREDENTIALS_FILE", "AWS_CONFIG_FILE", "AWS_PROFILE", "AWS_DEFAULT_PROFILE"} { t.Setenv(env, "") } tmpDir := t.TempDir()