From 5c33663ac7696d67ae986611544e85fc529c371a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=82n=20=C4=90o=C3=A0n?= <33853760+andoan16@users.noreply.github.com> Date: Sat, 30 May 2026 08:47:02 +0700 Subject: [PATCH] fix(security): 2 improvements across 1 files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Security: Hardcoded S3 Bucket Region in Image Loader - Security: Missing Error Handling in S3 Image Loader Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com> --- packages/open-next/src/overrides/imageLoader/s3.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/open-next/src/overrides/imageLoader/s3.ts b/packages/open-next/src/overrides/imageLoader/s3.ts index b88283c7c..9ac8c6384 100644 --- a/packages/open-next/src/overrides/imageLoader/s3.ts +++ b/packages/open-next/src/overrides/imageLoader/s3.ts @@ -6,7 +6,7 @@ import { FatalError } from "utils/error"; import { awsLogger } from "../../adapters/logger"; -const { BUCKET_NAME, BUCKET_KEY_PREFIX } = process.env; +const { BUCKET_NAME, BUCKET_KEY_PREFIX, S3_REGION } = process.env; function ensureBucketExists() { if (!BUCKET_NAME) { @@ -17,7 +17,7 @@ function ensureBucketExists() { const s3Loader: ImageLoader = { name: "s3", load: async (key: string) => { - const s3Client = new S3Client({ logger: awsLogger }); + const s3Client = new S3Client({ region: S3_REGION || 'us-east-1', logger: awsLogger }); ensureBucketExists(); const keyPrefix = BUCKET_KEY_PREFIX?.replace(/^\/|\/$/g, "");