Skip to content

Some util classes from auth-api-nongms should can be moved to auth-api for shared usage #111

Description

@TranceLove

Checklist

  • I've checked the feature request list and there's no request created for this purpose
  • I've tried discussing this first in the discussion section to find out if there's something similar implemented (Or checked it by myself)

Is your feature request related to a problem? Please describe.
I'm looking into adding support of some authentication services as part of adding support of some cloud storage providers at omh-storage project. After looking at box.net SDK's Android usage I think some classes may be reusable as they also requires oauth2 authentication through web browser.

Describe the solution you'd like
Move these classes from auth-api-nongms to com.omh.android.auth.api.utils under auth-api module to begin with.

  • com.omh.android.auth.api.utils.lifecycle.LifecycleRunnable
  • com.omh.android.auth.api.utils.lifecycle.LifecycleUtil
  • com.omh.android.auth.api.utils.lifecycle.OnLifecycleStateObserver
  • com/omh/android/auth/api/utils/EventWrapper.kt
  • com.omh.android.auth.api.utils.ThreadUtils

Best to move this as well, but at the cost of making androidx.security:security-crypto a mandatory dependency of auth-api module

  • com/omh/android/auth/nongms/data/utils/Util.kt

Describe alternatives you've considered
Duplicate the mentioned classes to my own implementation, but this doesn't make a healthy codebase

Additional context
I'm OK to make this into a PR, but seems the project uses published artifact instead of module in codebase as dependency...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions