Add intrafile tainting toggle and editor file/clear actions#59
Merged
Conversation
Previously --taint-intrafile was passed unconditionally on every scan and test run. Add a labelled toggle in a new "Scan options" section above the results panel that controls whether the flag is emitted, defaulting to ON to preserve existing behaviour. Flipping the toggle invalidates the current results to avoid showing output that no longer matches the selected options.
Add two buttons beside each editor title ("Rule" and "Code to Test"):
Load file... opens a native OS file picker via a new open-file-dialog IPC
handler and replaces the editor contents with the chosen file; Clear
empties the editor. The Rule picker is restricted to .yaml and .yml
files while the Code picker accepts any file. The dialog is attached to
the active BrowserWindow so it appears as a sheet on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--taint-intrafileis passed to scan and test runs (defaults to ON to preserve existing behaviour). Flipping the toggle invalidates the current results so they cannot mislead.open-file-dialogIPC handler, restricted to.yaml/.ymlfor the rule editor and any file for the code editor. Clear empties the editor (and disables Evaluate when the rule is cleared).