ci: consolidate hermetic validation - #65
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed August 14, 2026, 5:20 AM ET / 09:20 UTC. ClawSweeper reviewWhat this changesConsolidates Swift validation into one hermetic macOS/Linux workflow, adds a default-branch-only manual provider smoke workflow, removes disconnected examples and documents, and updates related documentation. Merge readinessKeep open for an explicit collaborator-owned merge decision. The latest head fixes the prior false-green live-provider gate, and no blocking patch defect was found; branch-protection status checks must be confirmed against the consolidated workflow before merge. Priority: P2 Review scores
Verification
How this fits togetherGitHub Actions builds, tests, and styles the Swift package on supported runners, while a separate manual workflow runs credentialed provider requests. These workflows turn repository source and provider credentials into merge signals for contributors and maintainers. flowchart LR
A[Source change] --> B[Hermetic CI]
B --> C[macOS and Linux validation]
A --> D[Manual provider workflow]
E[Repository secrets] --> D
D --> F[Live provider smoke tests]
C --> G[Merge status checks]
F --> G
Decision needed
Why: The diff demonstrably removes old workflow jobs, but repository branch-protection configuration is an external maintainer-controlled contract that source inspection cannot determine. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk options
Maintainer options:
Technical reviewBest possible solution: Land a single hermetic validation contract only after the protected-branch required-check set is confirmed or migrated to the new job names and the exact-head matrix completes successfully. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a CI and cleanup PR rather than a user-reported runtime failure; the updated workflow and test gates are directly inspectable in the proposed source. Is this the best way to solve the issue? Unclear until required-check continuity is confirmed. The consolidated workflow and fail-closed manual provider gate are coherent, but deleting old job names must not silently alter protected-branch enforcement. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7ec311aec8d4. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (3 earlier review cycles)
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Summary
Proof
TACHIKOMA_TEST_MODE=mock TACHIKOMA_DISABLE_API_TESTS=true swift test --parallel(837 Tachikoma tests + 57 MCP tests)TACHIKOMA_TEST_MODE=mock TACHIKOMA_DISABLE_API_TESTS=true swift build -c releaseswiftformat --lint .swiftlint lint --config .swiftlint.yml --strictactionlint .github/workflows/*.ymlScope
No provider/model runtime API, release, or tag behavior changes.