lua-lsm: skip empty kvcache dict free#23
Open
chenzongyao200127 wants to merge 1 commit into
Open
Conversation
kvcache_dict_free() can be called for objects that never stored Lua-visible key/value state. Walking an empty rbtree and taking the global nodes GC lock in that case is unnecessary work on object teardown paths. Return immediately when the dictionary count is zero. Non-empty dictionaries still take the existing lock and unlink every cached node as before. Signed-off-by: Zongyao Chen <ZongYao.Chen@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kvcache_dict_free() can run for Lua-LSM objects that never stored object-local or shared key/value state. In that case the dictionary rbtree is empty, so taking the global nodes GC lock and walking the tree does unnecessary teardown work.
Return immediately when the dictionary count is zero. Non-empty dictionaries keep the existing unlink and drop path unchanged.
Validation:
Signed-off-by: Zongyao Chen ZongYao.Chen@linux.alibaba.com