lua-lsm: reset dirty VMs on task exit#20
Open
chenzongyao200127 wants to merge 1 commit into
Open
Conversation
Lua VMs cached in the per-task pool can keep loaded module state after a policy lookup dirties the VM. When such a VM is recycled for another task, stale module tables may remain reachable unless the VM is cleaned first. Track dirty VMs and reset them from task_blob_free() before returning them to the pool. This drops loaded modules and restores the registry state at task exit, while leaving clean VMs on the fast reuse path. Signed-off-by: Zongyao Chen <ZongYao.Chen@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lua-LSM reuses per-task Lua VMs through the LVM pool. A VM that lazily loads a policy module can keep module tables and registry state after the task exits, so reusing that VM for a later task can leave stale Lua module state reachable.
Track when a VM has been dirtied by lazy module loading and reset it from task_blob_free() before returning it to the pool. Clean VMs still take the existing fast path, while dirty VMs drop loaded modules and restore the registry state at task exit.
Validation:
Signed-off-by: Zongyao Chen ZongYao.Chen@linux.alibaba.com