[Fix #1604] Zanini comments

Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>

Author: fjtirado

impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowApplication.java

@@ -149,7 +149,7 @@ private WorkflowApplication(Builder builder) {
     this.allStrategyCorrelationInfoFactory = builder.allStrategyCorrelationInfoFactory;
     this.lifeCycleCloudEventFactory = builder.lifeCycleCloudEventFactory;
     this.schedulerExecutorService = builder.schedulerExecutorService;
-    this.allowedCommands = builder.allowedCommands;
+    this.allowedCommands = Collections.unmodifiableSet(builder.allowedCommands);
   }
 
   public TaskExecutorFactory taskFactory() {

impl/core/src/main/java/io/serverlessworkflow/impl/executors/RunShellExecutor.java

@@ -23,6 +23,7 @@
 import io.serverlessworkflow.impl.WorkflowModel;
 import io.serverlessworkflow.impl.WorkflowValueResolver;
 import io.serverlessworkflow.impl.scripts.ScriptUtils;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;
@@ -52,13 +53,13 @@ public CompletableFuture<WorkflowModel> apply(
     String command = shellCommand.apply(workflowContext, taskContext, model);
     if (!workflowContext.definition().application().allowedCommands().contains(command)) {
       return CompletableFuture.failedFuture(
-          new IllegalAccessException(
+          new SecurityException(
               "Command "
                   + command
                   + " is not allowed. Please verify the set of allowed commands passed to the application"));
     }
 
-    List<String> commandAndArgs = new java.util.ArrayList<>();
+    List<String> commandAndArgs = new ArrayList<>();
     commandAndArgs.add(command);
     shellArguments.forEach(f -> commandAndArgs.add(f.apply(workflowContext, taskContext, model)));
 

impl/test/src/test/java/io/serverlessworkflow/impl/test/RunShellExecutorTest.java

@@ -71,7 +71,7 @@ void testEchoInvalid() throws IOException {
                     .instance(new Input(new User("John Doe")))
                     .start()
                     .join())
-        .hasCauseInstanceOf(IllegalAccessException.class);
+        .hasCauseInstanceOf(SecurityException.class);
   }
 
   @Test

impl/test/src/test/resources/workflows-samples/run-shell/echo-none.yaml

@@ -9,5 +9,5 @@ do:
         shell:
           command: echo
           arguments: 
-            - Javierito rulezzzz!!!!
+            - Open Workflow
         return: none