hcode-hw062823a.opmst failed to compile with Fedora 39 ppc64le

[runlevel5]

Info

I tried to build a RaptorCS blackbird firmware open-power/op-build#5256 on Fedora 39 ppc64le but got error with hcode-hw062823a.opmst (see Error Output)

I have tried GCC 8.4.0, 9.4, 10.4.0 and 12.3.0 but still produce the same error.

System Details Report

---

Report details

• Date generated: 2023-08-20 06:58:21

Hardware Information:

• Hardware Model: Raptor Computing Blackbird C1P9S01 REV 1.01
• Memory: 61.4 GiB
• Processor: POWER9, altivec supported × 32
• Graphics: AMD Radeon™ RX 6600 XT
• Disk Capacity: 8.0 TB

Software Information:

• OS Name: Fedora Linux 39 (Workstation Edition Prerelease)
• OS Arch: PowerPC 64 LE
• OS Type: 64-bit
• Kernel Version: Linux 6.5.0-0.rc6.20230816git4853c74bd7ab.45.fc39.ppc64le

Error Output

    p9_sgpe_img_edit.o
    CC         p9_dd_container.o
    AR         libcen_ringId.a
    C++        p9_scan_compression.o
    AR         libstop_gpeImgEdit.a
    C++        p9_tor.o
    AR         libp9_ring_identification.a
    AR         libp9_xip_image.a
    LD         pstate_gpeImgEdit.exe
    AR         libp9_dd_container.a
    LD         cmeImgEdit.exe
    LDSO       libp9_ringId.so
    AR         libp9_tor.a
    LDSO       libcen_ringId.so
    LD         stop_gpeImgEdit.exe
    C++        common_ringId.o
    LDSO       libp9_ring_identification.so
    LDSO       libp9_dd_container.so
    LDSO       libp9_xip_image.so
    AR         libcommon_ringId.ahcode-hw062823a
    LDSO       libp9_tor.so
    LDSO       libcommon_ringId.so
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C: In function ‘int rs4_embed_cmsk(CompressedScanData**, CompressedScanData*)’:
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:935:26: error: pointer ‘embeddedAddr’ may be used after ‘void* realloc(void*, size_t)’ [-Werror=use-after-free]
  935 |     memmove(embeddedAddr + embeddedSize,
      |             ~~~~~~~~~~~~~^~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:927:43: note: call to ‘void* realloc(void*, size_t)’ here
  927 |     *io_rs4 = (CompressedScanData*)realloc(*io_rs4, totalSize);
      |                                    ~~~~~~~^~~~~~~~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:940:11: error: pointer ‘embeddedAddr’ may be used after ‘void* realloc(void*, size_t)’ [-Werror=use-after-free]
  940 |     memcpy(embeddedAddr,
      |     ~~~~~~^~~~~~~~~~~~~~
  941 |            i_rs4Cmsk,
      |            ~~~~~~~~~~
  942 |            embeddedSize);
      |            ~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:927:43: note: call to ‘void* realloc(void*, size_t)’ here
  927 |     *io_rs4 = (CompressedScanData*)realloc(*io_rs4, totalSize);
      |                                    ~~~~~~~^~~~~~~~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:935:12: error: pointer ‘embeddedAddr’ may be used after ‘void* realloc(void*, size_t)’ [-Werror=use-after-free]
  935 |     memmove(embeddedAddr + embeddedSize,
      |     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  936 |             embeddedAddr,
      |             ~~~~~~~~~~~~~
  937 |             be16toh((*io_rs4)->iv_size) - sizeof(CompressedScanData));
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:927:43: note: call to ‘void* realloc(void*, size_t)’ here
  927 |     *io_rs4 = (CompressedScanData*)realloc(*io_rs4, totalSize);
      |                                    ~~~~~~~^~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [../../import/chips/p9/utils/imageProcs/p9_scan_compression.mk:32: ../../import/../output/obj/p9_scan_compression/p9_scan_compression.o] Error 1
make[2]: *** [common.dir/order.final.mk:41: _BUILD/MODULE_TARGETS] Error 2
make[1]: *** [Makefile:37: all] Error 2
make[1]: Leaving directory '/home/tle/Work/op-build/output/build/hcode-hw062823a.opmst'
make: *** [package/pkg-gene

[runlevel5]

I can also confirm this issue also impacts hcode-hw051123a.opmst

[dcrowell77]

@runlevel5 - What was your previously working level?

@sumitk56 @IlyaSmirnov91

[IlyaSmirnov91]

Looks like a real bug.

embeddedAddr is declared on line 922 based on io_rs4; then io_rs4 is realloc'ed on line 927, so its pointer could change and point somewhere different. The simple fix here is to declare embeddedAddr after realloc.

@sumitk56 , could you please take a look?

[runlevel5]

@runlevel5 - What was your previously working level?

This issue only occur on Fedora 37, 38 and 39 (rawhide) ppc64le.

I do not run into this issue with Ubuntu 22.04 ppc64le (with GCC 8.4.0)