[Bug]: Race state on unzipping cbz

[dajotim937]

Preflight Checklist

• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

OpenComic Version

1.6.6 / one from comments, iirc

Operating System

Win10

Installed via

exe

Steps to reproduce

1. Clear temp files (and cache(?))
2. Have 2+ cbz files big enought for OpenComic to unzip them 5+ seconds or so in one folder (will call it parent folder)
3. Open first cbz.
4. Immediately open parent folder from "url" bar.
5. And click on second cbz.

Expected Behavior

Interrupted unzipping of first cbz, opening second cbz

Actual Behavior

I did it two times on video, look on covers. I opened first cbz, then second. Reader loaded first one (yellow cover). Second time I opened 5th (blue cover) and then 4th (grey-ish cover). Reader loaded 5th cbz.

video.mp4

Yeah, randomly find out about this bug because opened wrong cbz lol. Sorry.=)

Error message

No response

Additional Information

No response

Sample file

No response

[ollm]

Thanks for reporting!

This should fix it 9cb81d3, although I recently made some performance improvements, so it's likely that the file will open before you have a chance to open another one.

If you'd like to try it out and help find bugs, you can install a nightly build.

Nightly builds: ollm/OpenComic-Nightly

[dajotim937]

Yep, can't reproduce even with pretty unrealistic timing and bigger cbzs.

---

Not sure if it's related but in console there are error messages pretty much on every image inside of cbz. I checked with viewer and with 7-zip -- there are no errors in those.

Error reading buffer for COLORLESS - c044#1 (v05) - p156 [Seven Seas Entertainment] [Digital] [1r0n] {HQ}.png C:\....\image.js:311 
Error: Input buffer has corrupt header: 
    at Sharp.metadata (C:\...\input.cjs:631:17)
    at metadata (C:\...\image.js:243:25)
    at async Sharp (C:\...\image.js:266:77)
    at async Object.callback (C:\...\image.js:306:36)
    at async startJob (C:\...\threads.js:112:24)

[ollm]

This is due to the performance improvements. Among them, I changed the way image dimensions are obtained so that only the first bytes of the image are read, reducing disk reads. Because of this, it may sometimes fail if the image is structured differently. In those cases, this warning is printed in the console (In yellow), and it retries by reading the full image instead.

I made this change so it fails less often dfe9777

Nightly builds: ollm/OpenComic-Nightly