From e927a74b43e0c8a5e3b23a7ed919c3e971eff4e6 Mon Sep 17 00:00:00 2001 From: alichherawalla Date: Sat, 14 Mar 2026 22:06:26 +0530 Subject: [PATCH 1/2] fix: remove async from onPress callback to satisfy void return type SonarCloud flagged a Promise-returning function passed to onPress which expects () => void. Dropping async/await since removeServer is fire-and-forget in this context. Authored-by: GLM --- src/screens/RemoteServersScreen.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/screens/RemoteServersScreen.tsx b/src/screens/RemoteServersScreen.tsx index c0c0f1fe..4719b137 100644 --- a/src/screens/RemoteServersScreen.tsx +++ b/src/screens/RemoteServersScreen.tsx @@ -104,9 +104,9 @@ export const RemoteServersScreen: React.FC = () => { { text: 'Delete', style: 'destructive', - onPress: async () => { + onPress: () => { if (activeServerId === server.id) setActiveServerId(null); - await remoteServerManager.removeServer(server.id); + remoteServerManager.removeServer(server.id); }, }, ] From 489ebc8ea359dc939cd69c615261f68af815ccf1 Mon Sep 17 00:00:00 2001 From: alichherawalla Date: Sat, 14 Mar 2026 22:25:13 +0530 Subject: [PATCH 2/2] fix: add .catch() to handle removeServer promise rejection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Addresses Gemini and Greptile review comments — shows error alert on deletion failure instead of silently swallowing the rejection. Authored-by: GLM --- src/screens/RemoteServersScreen.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/screens/RemoteServersScreen.tsx b/src/screens/RemoteServersScreen.tsx index 4719b137..ec453749 100644 --- a/src/screens/RemoteServersScreen.tsx +++ b/src/screens/RemoteServersScreen.tsx @@ -106,7 +106,9 @@ export const RemoteServersScreen: React.FC = () => { style: 'destructive', onPress: () => { if (activeServerId === server.id) setActiveServerId(null); - remoteServerManager.removeServer(server.id); + remoteServerManager.removeServer(server.id).catch(error => + setAlertState(showAlert('Deletion Failed', error instanceof Error ? error.message : 'An unknown error occurred.')) + ); }, }, ]