Allow putting cmd for linters or formatter declared with fn and detect if executables exist in `:Guard info`

[231tr0n]

Problem X you are solving:

Any linter or formatter declared using the fn function does not show up in the :Guard info command and the guard does not check for the availability of this executable.

Problems encountered under the status quo:

I have quite a few formatters and linters declared using the fn function which result in these formatters and linters not undergoing executable availability checks.

Suggested feature Y:

Change in the source code allowing declaration of both fn and cmd and checking for cmd even if fn is declared or not.

How to solve X now:

Allow declaring cmd with fn and check for the executable declared in cmd along with fn.

How can X be solved after feature Y is implmented:

Declaring cmd with fn results in the executable check being applied to all the linters and formatter declared using fn.

[xiaoshihou514]

It sounds useful, but it will break a lot of "cmd or fn" checks, and I don't want to introduce another new field for this.
Further discussion welcomed.

[231tr0n]

@xiaoshihou514 there is no need to introduce another field for this afaik. The checks can probably be changed in such a way that if fn is detected in the config along with cmd, just run fn and check for executable in cmd or if fn is not detected in the config, just run cmd with other declared args stuff and check for executable in cmd. The only thing which will probably change would be the checks.
It also results in a backward compatible behaviour not breaking any existing configurations.

[xiaoshihou514]

It would be backward compatible, but that would require a lot of logic updates for cmd-fn checks -- for a feature that is a nice to have, but not quite something most users (including me) would need.
The idea of fn is handing all responsibility to the user, and adding special logic for it, while reasonable (many fn use cases seem to use a command under the hood), doesn't feel quite right for that reason.
I am quite reluctant to put this in core and would suggest using vim.fn.executable in your own config for that.

[231tr0n]

I am quite reluctant to put this in core and would suggest using vim.fn.executable in your own config for that.

My main issue is that there is no way to show these executable checks even if I put it in my config in the guard health checks output. That was the reason behind me asking it.

It would be backward compatible, but that would require a lot of logic updates for cmd-fn checks -- for a feature that is a nice to have, but not quite something most users (including me) would need.
The idea of fn is handing all responsibility to the user, and adding special logic for it, while reasonable (many fn use cases seem to use a command under the hood), doesn't feel quite right for that reason.

@xiaoshihou514 afaik other way around would be to add a new config value like 'executable' key which will define the executable. You can then detect if a config uses fn and check if this key is present in the config and if present check for this executable in the health check command. This will only need change in the health check command logic and nothing else. This will also result in very minimal changes and is also not breaking any existing user config.

[xiaoshihou514]

I guess I could introduce an optional check function field.

[231tr0n]

I guess I could introduce an optional check function field.

Yeah this makes sense as well but at the end of the day it is just to check for executable so might as well make it support both string and function. If string is provided check for the executable in string else if function is provided use that. Although I don't think function will be used in most cases so it makes sense to probably just support string and check for the executable.

[xiaoshihou514]

#213

[xiaoshihou514]

Sorry for the delay :)

[231tr0n]

@xiaoshihou514 is it possible to show the health function status in the checkhealth guard output buffer?

[231tr0n]

Currently whether the health function succeed or not is not shown anywhere in the checkhealth guard buffer. It would be really helpful if that was the case.

[xiaoshihou514]

@231tr0n Just vim.health.ok or vim.health.error your self.