Skip to content

Add a warning about serializing to String in-place. #120

Description

@JohnScience

I was planning to use this library for building URLs.

However, I realized that the logical implementation of the serializer (which checks whether the string is empty) might have unexpected consequences for the users who want to extend the string with base URL with the query parameter string.

Rust Playground: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=d57620e0e8ed4c78bc08df02dd9d8928

While the behavior is reasonable and can be easily worked around, it still is not obvious.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions